Linting error: `account.inbox.filter(...)` about exchangelib HOT 9 CLOSED

I think this is just Pyright not being able to understand the code properly. I don't see anything wrong.

from exchangelib.

Just opened an issue at Pyright: microsoft/pyright#7378

from exchangelib.

Welp, pyright is blaming this repo for the error. Looking myself, it looks like it is perhaps an issue here. I think maybe we just need to export the list of attributes in an __all__ = [...] list. I'd have to look at it harder though.

from exchangelib.

pydanny/cached-property#172 is probably real issue. threaded_cached_property doesn't play well with static analysis tools in general.

The easiest trick,

if TYPE_CHECKING:
  my_prop = property
else:
  my_prop = threaded_cached_property

from exchangelib.

Most of exchangelib was written long before type annotations became a Python feature. Adding full annotations is a huge effort that I will not undertake myself, at least.

from exchangelib.

I wasn't suggesting that we need full annotations; I do however thing that it makes sense to add hints on parts that are being labelled as errors

from exchangelib.

In this case, it looks like the real issue lies in the cached-property package. I think the issue should be solved there.

There are other places where static type checkers have a hard time reasoning about exchangelib code. I haven't seen any cases where there were actual errors, and refactoring turned out to be a lot of work for very little gain.

I'm closing this issue because exchangelib doesn't use Pyright. I'm not generally opposed to doing so, but please work on adding support in a PR instead.

from exchangelib.

@ecederstrand, would you be willing to help me write an issue for this in the cached-property package? Or at least point me to the part where that issue needs to be referenced as an example of the issue?

from exchangelib.

The issue already exists. pydanny/cached-property#172 is the correct issue. Fixing that will fix the problem here.

from exchangelib.