ecerroni / apollo-cache-updater Goto Github PK

View Code? Open in Web Editor NEW

160.0 160.0 5.0 5.5 MB

Helper for updating the apollo cache after a mutation

License: MIT License

JavaScript 100.00%

apollo-cache-updater's People

Contributors

Stargazers

Watchers

Forkers

matthewk richardgrac amorriscode bhwanip dingzhanjun

apollo-cache-updater's Issues

Wrong queries get updated in the cache instead of those targeted

If different queries have the same exact variables there are some cases where the wrong queries get updated in the cache.

Generally confused on how this package works

I currently have this in my code:

update: (store, { data: { deleteTracks } }) => {
  const updates = ApolloCacheUpdater({
    proxy: store,
    queriesToUpdate: [getTracksQuery],
    searchVariables: {
      // ??
    },
    mutationResult: deleteTracks,
  });
},

It just so happens that my delete mutation returns an array of IDs that were actually found and deleted, but the cache updater doesn't like this:

ApolloCacheUpdater Error: mutationResult cannot be an array | [mutation-result_no-array]

I'm also not totally sure I'm using searchVariables properly.

Bug: Cannot assign to read only property

Although queries in the cache should not be frozen, sometimes it still happens. I've not understood what is the exact reason of this.

The error message is:
TypeError: Cannot assign to read only property '__my_query_name__' of object '#<Object>'

Cache update does not rerender

Issue:

When adding a new Employee, ApolloCacheUpdater successfully updates the cache but does not trigger a re-render ( shown once the page is refreshed).

Info:

REMOVE is working as intended and triggers a re-render upon completion.

Client Options:

fetchPolicy: 'cache-and-network',
errorPolicy: 'all',
notifyOnNetworkStatusChange: true,
returnPartialData: true

Image

The following image shows:

Console log: Created Employee & ApolloCacheUpdater ran successfully
Apollo Extension: Shows the Employee in cache
Table: Empty table
employees object: data object from const { loading, data, refetch } = useQuery(GET_EMPLOYEES)

Bug: old element is moved to new queries

When an element is moved from a query to another the old element (before the mutation result) is moved instead of the updated value

Not working with @client directive

Hi! First of all thank you for this awesome helper.

I'm just having trouble making it work with @client directive. Below is my query

const TODO_MANY = gql`
  query {
    todoMany {
      _id
      title
      isOptimistic @client
    }
  }
`;

const ADD_TODO = gql`
  mutation TodoCreateOne($input: CreateOneTodoInput!) {
    todoCreateOne(record: $input) {
      record {
        _id
        title
      }
      recordId
    }
  }
`;

Here's my onClick callback

const onClick = useCallback(() => {
    const id = uuid();
    addTodo({
      variables: {
        input: {
          title: 'test12',
        },
      },
      optimisticResponse: {
        __typename: 'Mutation',
        todoCreateOne: {
          __typename: 'CreateOneTodoPayload',
          recordId: id,
          record: {
            __typename: 'Todo',
            title: 'test12',
            _id: id,
            isOptimistic: true,
          },
        },
      },
      update: (cache, { data: { todoCreateOne } }) => {
        const updates = ApolloCacheUpdater({
          proxy: cache,
          queriesToUpdate: [TODO_MANY],
          operation: {
            type: 'ADD',
            add: ({ query, type, data, variables }) => {
              console.log('Calling Add');
              const rec = todoCreateOne.record;
              return [rec, ...data];
            },
          },
          searchVariables: {},
          mutationResult: todoCreateOne,
          ID: 'recordId',
        });
        if (updates) console.log(`Success`);
      },
    });
  }, []);

It is working without @client. "Calling Add" is displaying in console
but when I add @client, add function is not executing.

Note : I also tried doing the cache update manually and it works.

        const queryData = cache.readQuery({ query: TODO_MANY });
        cache.writeQuery({
           query: TODO_MANY,
           data: {
             todoMany: [
               ...queryData.todoMany,
               {
                 ...todoCreateOne.record,
               },
             ],
          },
        });

Thank you.

Feat request: Typescript support

Hi! Just wanted to know the feasibility of adding declaration typescript files (since the project is solely built on javascript) This would be a great addition for pure Typescript projects.

Thanks,

ecerroni / apollo-cache-updater Goto Github PK

apollo-cache-updater's People

Contributors

Stargazers

Watchers

Forkers

apollo-cache-updater's Issues

Wrong queries get updated in the cache instead of those targeted

Generally confused on how this package works

Bug: Cannot assign to read only property

Cache update does not rerender

Issue:

Info:

Client Options:

Image

Bug: old element is moved to new queries

Not working with @client directive

Feat request: Typescript support

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent