echannel / settingcrazy Goto Github PK
View Code? Open in Web Editor NEWLicense: MIT License
License: MIT License
This behavior makes sense at first glance, but lacks flexibility if the model doesn't need all namespaced setting templates to be validated.
One use case describes as follows:
To reproduce this issue:
s = Scenario.last # At this point the scenario doesn't have any setting values
s.settings.google.daily_budget = '1'
s.save!
s.settings.yahoo.daily_budget # => nil, which is correct
s.settings.yahoo # => {:daily_budget=>"1"}, wrong
Validations are used when we use a setting template. We should add if/unless options to setting namespace and use_setting_template to control when validations are applied. Eg;
use_setting_template FooTemplate, :validate_if => Proc.new { ... }
Two ways to reproduce this issue:
a) in settingcrazy gem, change line #10 to:
before { subject.foo = "bar"; subject.inspect; model.save! }
and 3 examples would fail, or
b) fires up rails console of DC app, do the following:
vi = Scenario::Campaign::VendorInstance.last # make sure this instance doesn't have setting values at this point
vi.settings.platform = '1'
vi.settings # => {} not {:platform => '1'}
vi.save! # setting for platform is not saved
I believe line #70 in settings_proxy.rb causes this issue.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.