echannel / settingcrazy Goto Github PK

This behavior makes sense at first glance, but lacks flexibility if the model doesn't need all namespaced setting templates to be validated.

One use case describes as follows:

• A scenario can be published to multiple search engines, e.g Google and Yahoo.
• The Scenario model has both google and yahoo as setting namespace.
• However, an individual scenario record may only wish to be published to Google, in which case validating Yahoo setting_values is not necessary and what even worse is the required option would fail the validation, such as Yahoo budget is not in place.

To reproduce this issue:

s = Scenario.last # At this point the scenario doesn't have any setting values
s.settings.google.daily_budget = '1'
s.save!
s.settings.yahoo.daily_budget # => nil, which is correct
s.settings.yahoo # => {:daily_budget=>"1"}, wrong

Validations are used when we use a setting template. We should add if/unless options to setting namespace and use_setting_template to control when validations are applied. Eg;

use_setting_template FooTemplate, :validate_if => Proc.new { ... }

Two ways to reproduce this issue:

a) in settingcrazy gem, change line #10 to:

before    { subject.foo = "bar"; subject.inspect; model.save! }

and 3 examples would fail, or

b) fires up rails console of DC app, do the following:

vi = Scenario::Campaign::VendorInstance.last # make sure this instance doesn't have setting values at this point
vi.settings.platform = '1'
vi.settings # => {} not {:platform => '1'}
vi.save! # setting for platform is not saved

I believe line #70 in settings_proxy.rb causes this issue.