echelon78 / bitcoinsharp Goto Github PK

What steps will reproduce the problem?
1. Create wallet
2. Wire CoinsRecieved event handler
3. Save wallet

What is the expected output? What do you see instead?
The wallet should save to disk. Instead, a SerializationException is thrown.

Please provide any additional information below.

Apparently, if you have a Serializable class with event handlers, 
BinaryFormatter will try to serialize the handling classes unless you 
specifically mark them as NonSerialized. The easy fix is to add the following 
attribute to all Serializable class events:

[field: NonSerialized()]

I'd submit a patch but I'm not sure how to do that. :)

When I try to svn checkout http://bitcoinsharp.googlecode.com/svn/trunk/ 
bitcoinsharp-read-only
subversion tells me that svn: URL 
'http://bitcoinsharp.googlecode.com/svn/trunk' doesn't exist

Any ideas?

What steps will reproduce the problem?
1. run BitCoinSharp.Examples.exe pingservice -prodnet


What is the expected output? What do you see instead?
Block Chain should be downloaded but programm stays forever wiht the prompt: 

Reading block store from disk
Connecting ...

What version of the product are you using? On what operating system?
Win 7 64 Sp1
latest source from http://bitcoinsharp.googlecode.com/svn


Please provide any additional information below:

When debugging I see that StartBlockChainDownload(IPeerEventListener listener), 
in PeerGroups.cs line 358 is called one time. There we have the condition:  if 
(firstPeer != null)
                        StartBlockChainDownloadFromPeer(firstPeer);

but firstPeer is null and StartBlockChainDownloadFromPeer(firstPeer); is never 
executed.

What steps will reproduce the problem?
1. Open BitcoinSharp.Examples
2. Run the PingService example.
3. crash...

What is the expected output? 
The expected output was that the PingService would connect to the localhost 
node.

What do you see instead?
System.ArgumentOutOfRangeException: Non-negative number required.
Parameter name: maximumCount at System.Threading.Semaphore..ctor(Int32 
initialCount, Int32 maximumCount, S
tring name)
   at BitCoinSharp.DownloadListener..ctor() in C:\path\to\BitcoinSharp\src\Core\DownloadListener.cs:line 39
   at BitCoinSharp.PeerGroup.DownloadBlockChain() in C:\path\to\BitcoinSharp\src\Core\PeerGroup.cs:line 384
   at BitCoinSharp.Examples.PingService.Run(String[] args) in C:\path\to\BitcoinSharp\src\Examples\PingService.cs:line 102
   at BitCoinSharp.Examples.Program.Main(String[] args) in C:\path\to\BitcoinSharp\src\Examples\Program.cs:line 38


What version of the product are you using? On what operating system?
Latest version from source code (as of 05/13/2012): 0.2.199.60
Operating System: Windows 7 Professional x64 SP1

Please provide any additional information below.
The issue occurs because the DownloadLinstener (DownloadListener.cs) attempts 
to construct a Semaphore (on line 39) with invalid parameters:
private readonly Semaphore _done = new Semaphore(0, 0);

A Semaphore requires a maximumCount of at least 1, otherwise the constructor 
throws an System.ArgumentOutOfRangeException (see 
http://msdn.microsoft.com/en-us/library/e1hct27h%28v=vs.100%29.aspx).

In order to fix this, the Semaphore must be initialized with at least 1 as 
maximumCount:
private readonly Semaphore _done = new Semaphore(0, 1);

In the home page there's a link for API documentation to 
http://bitcoinj.googlecode.com/svn/trunk/docs/index.html
That URL doesn't exist.

The documentation isn't here either: http://bitcoinsharp.googlecode.com/svn/

thanks!

What steps will reproduce the problem?
1. install bitcoin testnet sandbox
2. run BitCoinSharp.Examples PingService -testnet
3. bitcoin-qt receives all input, but don't answer

What is the expected output? What do you see instead?

I.don't know. Any...

What version of the product are you using? On what operating system?

bitcoin-qt 0.5.2 beta
lastversion  bitcoinsharp

dsa

when doing Fetchblock, the program prints out "Connecting to node" and then 
times out.  I am tailing debug.log on bitcoind, and i see that bitcoind had 
accepted the connection from 127.0.0.1, but thats as far as that goes.

Is this code being supported?  is it worth the trouble of figuring out?

What steps will reproduce the problem?
1. Build.
2.
3.

What is the expected output? What do you see instead?
A .net portable assembly.

What version of the product are you using? On what operating system?
latest.

Please provide any additional information below.

If it was a portable assembly it would be runnable on many more platforms 
(windows phone for example). You'd have to get a portable version of bouncy 
castle though, and probably drop the log4net dependency and just create your 
own ILog interface (better idea anyway, just let callers pass you their 
loggers, these static references to loggers are unsavory).

What steps will reproduce the problem?
1. Open BitcionSharp.Examples
2. Run the PingService example with -prodnet option.
3. crash...

Note that there was no local node to which to connect, so I also attempted the 
same test by discovering nodes from the ProdNet:

var peerGroup = new PeerGroup(blockStore, @params, chain);
//peerGroup.AddAddress(new PeerAddress(IPAddress.Loopback));

DnsDiscovery dns = new DnsDiscovery(NetworkParameters.ProdNet());
List<EndPoint> peers = new List<EndPoint>(dns.GetPeers());
foreach (EndPoint peer in peers)
{
    peerGroup.AddAddress(new PeerAddress((IPEndPoint)peer));
}

peerGroup.Start();


What is the expected output? What do you see instead?
I was expecting that a connection with the local host will be established.

System.Net.Sockets.SocketException: No connection could be made because the 
target machine actively refused it 127.0.0.1:8333

Full Stack Trace:
at System.Net.Sockets.Socket.DoConnect(EndPoint endPointSnapshot, SocketAddress 
socketAddress)
   at System.Net.Sockets.Socket.Connect(EndPoint remoteEP)
   at BitCoinSharp.NetworkConnection..ctor(PeerAddress peerAddress, NetworkParameters params, UInt32 bestHeight, Int32 connectTimeout) in C:\path\to\BitcoinSharp\src\Core\NetworkConnection.cs:line 72
   at BitCoinSharp.Peer.Connect() in C:\path\to\BitcoinSharp\src\Core\Peer.cs:line 105
   at BitCoinSharp.PeerGroup.<>c__DisplayClass4.<TryNextPeer>b__1() in C:\path\to\BitcoinSharp\src\Core\PeerGroup.cs:line 288
   at BitCoinSharp.Threading.Runnable.Run() in C:\path\to\BitcoinSharp\src\Core\Threading\Runnable.cs:line 58
   at BitCoinSharp.Threading.Execution.ThreadPoolExecutor.RunWorker(Worker worker) in C:\path\to\BitcoinSharp\src\Core\Threading\Execution\ThreadPoolExecutor.cs:line 1569
   at BitCoinSharp.Threading.Execution.AbstractExecutorService.OnThreadException(IRunnable sender, Exception exception) in C:\path\to\BitcoinSharp\src\Core\Threading\Execution\AbstractExecutorService.cs:line 1471
   at BitCoinSharp.Threading.Execution.ThreadPoolExecutor.RunWorker(Worker worker) in C:\path\to\BitcoinSharp\src\Core\Threading\Execution\ThreadPoolExecutor.cs:line 1574
   at BitCoinSharp.Threading.Execution.ThreadPoolExecutor.Worker.Run() in C:\path\to\BitcoinSharp\src\Core\Threading\Execution\ThreadPoolExecutor.cs:line 391
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()}

What version of the product are you using? On what operating system?
Latest version from source code (as of 05/13/2012): 0.2.199.60
Operating System: Windows 7 Professional x64 SP1

Please provide any additional information below.
The fundamental problem is that the Peer object fails to catch a 
SocketException when attempting to connect to an unreachable peer. The 
exception is not caught by the catch statements, which are supposed to raise a 
PeerException if an exception is to occur. The unhandled exception is raised in 
a background thread and it subsequently crashes the application. The faulty 
method is Peer.Connect, line 105 of Peers.cs:

try
{
    _conn = new NetworkConnection(_address, _params, _bestHeight, 60000);
}
catch (IOException ex)
{
    throw new PeerException(ex);
}
catch (ProtocolException ex)
{
    throw new PeerException(ex);
}

A possible work around is to either specifically catch the SocketException or 
to catch a generic Exception:

catch (Exception ex)
{
    throw new PeerException(ex);
}