eclipse-che / che-lib Goto Github PK

It make sense to update xterm.js terminal to the newer version. Very soon (about one-two weeks or even less) will be released xterm.js 3.0.

https://github.com/xtermjs/xterm.js

I would like to collect opinions about changing encoder for file logs(Important note: human readable Console log will remain the same)
from

        <encoder>
            <charset>utf-8</charset>
            <pattern>%-41(%date[%.15thread]) %-45([%-5level] [%.30logger{30} %L]) - %msg%n</pattern>
        </encoder>

to

 <encoder class="net.logstash.logback.encoder.LogstashEncoder" />

Example not formatted

{"@timestamp":"2017-11-19T20:37:00.893+00:00","@version":1,"message":"Workspace ID: workspace5pudf9crvcnrbrks","logger_name":"org.eclipse.che.
api.project.server.WorkspaceHolder","thread_name":"localhost-startStop-1","level":"INFO","level_value":20000}

Example formatted:

{
  "@timestamp": "2017-11-19T20:37:00.893+00:00",
  "@version": 1,
  "message": "Workspace ID: workspace5pudf9crvcnrbrks",
  "logger_name": "org.eclipse.che. api.project.server.WorkspaceHolder",
  "thread_name": "localhost-startStop-1",
  "level": "INFO",
  "level_value": 20000
}

Proc:

1. It has fixed format, will be easy to parse with different tools like jq
2. timestamp,thread_name , logger_name are not truncated .
3. Massage takes a single line. In some cases, if log contains multiline comment it's very hard to parse it with tools. With json format, it won't be a problem.
4. We may consider in future using Logstash as a default log collection backend for a multi-user mode.

Cons:

1. Larger file. I expect ~ 30%
2. Expected cons from 1) it will be a bit slower.

I've now tried to build che-lib in Brew and in che.openshift.io and in both places, the build fails to apply patches, but all the other projects build OK.

Che Plugin :: Orion-14.0 :: Editor ................. FAILURE [ 1.612 s]

Reproduction Steps:

. Start che.openshift.io
. Import this project - https://github.com/eclipse/che-lib - from master branch
. In console:

cd che-lib; mvn clean install -DskipTests -fn

Result:

compilation fails:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-patch-plugin:1.1.1:apply (bugfix-patches) on project che-orion-editor: Patch command failed with exit code 127 for fix_linked_mode.diff. Please see console and debug output for more information. -> [Help 1]

Che version:

6.9.0-SNAPSHOT

OS and version:

Linux workspace9nt5vd6igtvs72x2.dockerimage 3.10.0-862.3.2.el7.x86_64 #1 SMP Tue May 15 18:22:15 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux

Docker version:

(docker is not installed in my che.openshift.io workspace console)

Che cli.log output:

No such file or directory

We should remove unused terminal server side code. This code was moved to the https://github.com/eclipse/che/tree/master/agents/go-agents/terminal-agent . But old code still exists.