eclipse-ee4j / eclipselink-asm Goto Github PK

I want to create a new 9.1 release branch/tag. I want to have this 9.1 release branch/tag before we deliver any 9.2 or 10 updates, but I want to wait until we have all of the base files in place (readme files, build files, ect) so that we don't have to deliver to multiple branches.

In a conversation (eclipse-ee4j/eclipselink#1226 (review)) it's come up that we need a better way to keep Eclipselink pointing to the most current Opcodes.ASM## constant, as it's easy to forget to update ClassWeaver.java, MethodWeaver.java, and MetadataAsmFactory.java and end up with an updated ASM but an Eclipselink which is not able to take advantage of the new level's capabilities.

The suggestion is to add EclipseLinkClassVisitor extends ClassVisitor/EclipseLinkMethodVisitor extends MethodVisitor which must be updated when newer ASM## constants are introduced.

There are few places which need to be updated when ASM is being updated. It would be good have them listed in an issue template, so they are not forgotten to be updated

• versionMap in EclipseLinkASMClassWriter

ASM 9.2 was released last month.

Looks like Eclipse legal approved ASM 9.2 (https://dev.eclipse.org/ipzilla/show_bug.cgi?id=23713), so we should be able to go ahead and publish a 9.2 level binary.

See this commit in the other project:

eclipse-ee4j/eclipselink@140718f

This project is on 9.4.0-SNAPSHOT though, see last commit here:

0e6253a

ASM 9.5 is has now been released, as announced on https://asm.ow2.io/versions.html

Created PR #24 for this, which also documents the IP Review requests for the ASM 9.5 dependencies.