Giter VIP home page Giter VIP logo

Comments (2)

lukez963 avatar lukez963 commented on July 4, 2024 3

Hi, could I be assigned this issue?

from jkube.

lukez963 avatar lukez963 commented on July 4, 2024

Hi. I'm unsure if creating a OpenShiftJKubeMojo interface would work here. The interface OpenShiftJKubeTask is overriding the getLogPrefix() default implementation from the KubernetesJKubeTask interface.
However, all OpenShift Maven Plugin Mojo classes inherit their getLogPrefix() implementation from abstract classes (either AbstractJKubeMojo or AbstractDockerMojo) - if the overriding getLogPrefix() is removed from each Mojo class and moved to the OpenShiftJKubeMojo interface, I believe the classes will preferentially call the getLogPrefix() implementation from AbstractJKubeMojo or AbstractDockerMojo instead.
The simplest solution to this I see is to move the getLogPrefix() implementation from AbstractJKubeMojo and AbstractDockerMojo to the interface KitLoggerProvider, which they both implement (I believe the proposed interface OpenShiftJKubeMojo would successfully override getLogPrefix then). But this wouldn't work if KitLoggerProvider is meant to be a functional interface or for other reasons I don't see.

from jkube.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.