JavaExecGenerator does not honor %t setting about jkube HOT 4 CLOSED

@ecausarano : Is it possible to share a reproducer project? I tried reproducing this but could not reproduce the issue. Here are the steps I followed:

1. Clone https://github.com/rohankanojia/podsetoperatorinjava
2. Change jkube.generator.name property in pom.xml to quay.io/${image.user}/${project.artifactId}:%t
3. Run mvn k8s:build

I was able to see image being tagged with timestamp:

[INFO] k8s: [quay.io/rohankanojia/podset-operator-in-java:snapshot-240613-102153-0649] "java-exec": Created docker-build.tar in 65 milliseconds
[INFO] k8s: [quay.io/rohankanojia/podset-operator-in-java:snapshot-240613-102153-0649] "java-exec": Built image sha256:4d492
[INFO] k8s: [quay.io/rohankanojia/podset-operator-in-java:snapshot-240613-102153-0649] "java-exec": Tag with latest

from jkube.

okay, I think I now understand the problem now. Image is correctly tagged with timestamp, however JKube is adding an additional <tag> in Build configuration. This results in an extra image getting created:

REPOSITORY                                     TAG                           IMAGE ID       CREATED              SIZE
quay.io/rohankanojia/podset-operator-in-java   latest                        dd581f0fe6ef   About a minute ago   507MB
quay.io/rohankanojia/podset-operator-in-java   snapshot-240613-102851-0116   dd581f0fe6ef   About a minute ago   507MB

This latest tag is being added for projects that have versions containing SNAPSHOT

Adding a check here to not add latest tag when image name contains %t fixes the issue

-        if (getProject().getVersion().endsWith("-SNAPSHOT")) {
+        if (getProject().getVersion().endsWith("-SNAPSHOT") && !getImageName().contains("%t")) {

from jkube.

That would fix it, but the tag name is already processed in another part of the codebase. (ImageNameFormatter.java

I'm no Docker guru, is there a reason for explicitly adding the latest tag? Wouldn't the Registry automatically add it?

from jkube.

I'm checking history of this change and it seems to have been introduced in fabric8io/fabric8-maven-plugin#186 . It doesn't provide much insight on why this was added.

from jkube.