Giter VIP home page Giter VIP logo

Comments (8)

sidd3888 avatar sidd3888 commented on August 9, 2024

For the case of the multivariate lognormal discretization where the covariance matrix is not diagonal, I have added a feature of tails and a truncated distribution. What I have not done is actually implement a functionality for distinct tail points. That is, even if you currently specify tail_N = 3, it will create 3 copies of the boundary point. I was wondering whether these endpoints should be made manual or perhaps we can automatically choose some such points based on the bound on the CDF and the number of tail points. I have pushed the changes to the PR with a new function called _approx_equiprobable2 under the MVLogNormal class.

from hark.

mnwhite avatar mnwhite commented on August 9, 2024

I'm currently working on this, but the code isn't in the state that I thought it was. For whatever reason, I thought that that limit attribute of discrete distributions contained the upper and lower support bounds for the true distribution-- its limits, in shorthand. It actually contains information about the continuous distribution from which the discretization was generated. Why is this called limit?

from hark.

alanlujan91 avatar alanlujan91 commented on August 9, 2024

limit contains info on the limiting distribution as you increase the number of points.
Chris wanted the upper and lower bounds to be part of the atoms themselves.

from hark.

mnwhite avatar mnwhite commented on August 9, 2024

I don't think that's going to work, at least not without adding quite a bit of code. A lot of distribution families have unbounded support, at least on one side: normal, lognormal, exponential, Weibull, T1EV, etc. If we literally put infinitesimally weighted atoms at the lower and upper bounds of discretizations, that would be +/- infinity for a lot of distributions, which would break a lot of calculations. We would have to require that all continuous distributions have bounded support.

from hark.

alanlujan91 avatar alanlujan91 commented on August 9, 2024

Right, but then how do we accomplish np.min(lognorm.atoms) = 0.0 ?

from hark.

mnwhite avatar mnwhite commented on August 9, 2024

I don't think we can/should, that's what I'm saying. I'm in the process of putting this information in new attributes of Distribution called infimum and supremum, which then get distributed to DiscreteDistribution as part of the limit. Then users can query that if they want to use it.

from hark.

mnwhite avatar mnwhite commented on August 9, 2024

Ack, I just realized that the entry for the distribution itself is dist, but it should be dstn.

from hark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.