Giter VIP home page Giter VIP logo

gregorian's Issues

diff_days & diff_date behavior for BCE

Hi Edgar,

I think I found an issue with taking the difference between between BCE dates.

In the example below I was expecting ~21 days as the difference between dates-but it looks like it's summing to 40. It might be adding the 10 offset in January with the 30 day difference between.

begin_date <- gregorian::as_gregorian("-800-01-10")
end_date <- gregorian::as_gregorian("-800-02-01")
date_diff <- gregorian::diff_days(end_date, begin_date)
print(date_diff)

Changing January 10th to January 1st will give a more expected value 31.

begin_date <- gregorian::as_gregorian("-800-01-1")
end_date <- gregorian::as_gregorian("-800-02-01")
date_diff <- gregorian::diff_days(end_date, begin_date)
print(date_diff)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.