edgarsgarsneks / eg-radar Goto Github PK

Description

Tooltip text being cut when near right margin making text unreadable.

Expected Behavior

When text cannot fully fit the screen, it's position should be adjusted to fit (if possible, not talking about unreasonable text lengths).

How To Reproduce?

This issue can be reproduced with following config

{
    "width": 300,
    "style": { "seed": 34 },
    "sectors": [
        { "label": "Sector 1"},
        { "label": "Sector 2"},        
        { "label": "Sector 2"}
    ],
    "rings": [
        { "label": "Ring1",  "color": "green" },
        { "label": "Ring2",  "color": "green" }    
    ],
    "entries": [ { "label": "My Longer Text", "sector": 0, "ring": 1, "moved": 0 } ]
}

Solution Proposal

In the RadarRenderer.ts in showTooltip method include necessary position update in "transform" attribute.

Description

Tests should be run automatically on created PRs, to insure quality and reduce manual interactions.

Expected Behavior

Tests should automatically be executed and test report should be provided in the PR comments. If there are tests failures, PR should be blocked from merging.

Solution Proposal

Implement via GitHub workflow using GitHub actions https://github.com/features/actions