edgexfoundry / core-command-go Goto Github PK

In device.go, commandByDeviceID function, line 62:

url := d.Service.Addressable.GetBaseURL() + strings.Replace(c.Put.Action.Path, DEVICEIDURLPARAM, d.Id.Hex(), -1)

That will be an issue if the command doesn't have a Put method. If the command is read-only, the path should come from c.Get.Action.Path

AFter a git clone repository and glide install, go install is failing.

$ go install
# github.com/edgexfoundry/core-command-go
./StartCommand.go:51: not enough arguments in call to consulclient.CheckKeyValuePairs
	have (*ConfigurationStruct)
	want (interface {}, string, []string)
./device.go:29: not enough arguments in call to metadataclients.NewDeviceClient
	have ()
	want (string)
./device.go:38: d.IsLocked undefined (type models.Device has no field or method IsLocked)
./device.go:44: not enough arguments in call to metadataclients.NewCommandClient
	have ()
	want (string)
./device.go:53: undefined: issueCommand
./device.go:60: undefined: issueCommand
./device.go:68: not enough arguments in call to metadataclients.NewDeviceClient
	have ()
	want (string)
./device.go:69: assignment count mismatch: 2 = 1
./device.go:78: not enough arguments in call to metadataclients.NewDeviceClient
	have ()
	want (string)
./device.go:79: assignment count mismatch: 2 = 1
./device.go:79: too many errors

For California Release - get Go core command configuration into config-seed and have Go command use Consul on initialization

Command Service outputs tuned Device objects (in the form of CommandResponse objects).

Diff from Device to CommandResponse:
-addressable, -service, -profile
+commands as profile.commands

@bullapse

Hi,

I tried to get it with go get command and this error is triggered :

root@seo:/develop/core-command-go# go get github.com/edgexfoundry/core-command-go
package github.com/edgexfoundry/core-command-go
imports github.com/edgexfoundry/consul-client-go
imports github.com/hashicorp/consul/api
imports context: unrecognized import path "context"

my go version is "go1.9.2"