Device Discovery should use EndpointReference for uniqueness about device-onvif-camera HOT 3 CLOSED

@ajcasagrande
The modification can be done with the following steps:

1. Parse the EndpointReference from the probe response. https://github.com/IOTechSystems/onvif/blob/master/ws-discovery/networking.go#L43-L56
2. Replace the serial number with EndpointReference when discovering the device. https://github.com/edgexfoundry-holding/device-onvif-camera/blob/main/internal/driver/driver.go#L328

from device-onvif-camera.

@ajcasagrande do you agree with Bruce's solution?

from device-onvif-camera.

@ajcasagrande

I can get the EndpointReference from probe message as below two cameras:

TAPO C200

<wsdd:ProbeMatch>
  <wsa:EndpointReference>
    <wsa:Address>uuid:3fa1fe68-b915-4053-a3e1-c006c3afec0e</wsa:Address>
     <wsa:ReferenceProperties></wsa:ReferenceProperties><wsa:PortType>ttl</wsa:PortType>
  </wsa:EndpointReference>
  <wsdd:XAddrs>http://192.168.12.128:2020/onvif/device_service</wsdd:XAddrs>
  ...
</wsdd:ProbeMatch>

HIKVISION

<d:ProbeMatch>
 <wsadis:EndpointReference>
    <wsadis:Address>urn:uuid:cea94000-fb96-11b3-8260-686dbc5cb15d</wsadis:Address>
 </wsadis:EndpointReference>
 <d:XAddrs>http://192.168.12.123/onvif/device_service</d:XAddrs>
 ...
</d:ProbeMatch>

So we need to extract the uuid value 3fa1fe68-b915-4053-a3e1-c006c3afec0e and cea94000-fb96-11b3-8260-686dbc5cb15d to replace the serial number. Is that correct?

The PRs opened, could you help verify that?
#7
IOTechSystems/onvif#8

from device-onvif-camera.