Startup delay/blocking when missing credentials about device-onvif-camera HOT 3 CLOSED

The device service tries to get the credential if the camera required authentication.
Here's the function to get the credential
https://github.com/edgexfoundry-holding/device-onvif-camera/blob/c64c8ceb32d9e245c546dc7983f6cd9184b271bd/internal/driver/driver.go#L265-L274
The user can decrease CredentialsRetryTime by overriding the env DRIVER_CREDENTIALSRETRYTIME.

from device-onvif-camera.

@weichou1229 I think the problem is that on startup this is not done asynchronously. Thus one camera with missing credentials will hold up the N number of cameras with valid credentials.

from device-onvif-camera.

I think the problem is that on startup this is not done asynchronously. Thus one camera with missing credentials will hold up the N number of cameras with valid credentials.

@ajcasagrande Yes, it blocks the initialization, does this modification works for you?

	for _, device := range deviceService.Devices() {
		// onvif client should not be created for the control-plane device
		if device.Name == d.serviceName {
			continue
		}
		go func() {
			d.lc.Infof("Initializing onvif client for '%s' camera", device.Name)

			onvifClient, err := d.newOnvifClient(device)
			if err != nil {
				d.lc.Errorf("failed to initialize onvif client for '%s' camera, skipping this device.", device.Name)
				return
			}
			d.clientsMu.Lock()
			d.onvifClients[device.Name] = onvifClient
			d.clientsMu.Unlock()
		}()
	}

from device-onvif-camera.