eduwireapps / kdecole-api-dart Goto Github PK

I inspected the code of the Client and it looks like the invokeApi uses an url parameter. This parameter is always provided as url + something so this url that is a class attribute could be used directly within invokeApi.
Also it should be a private method I think.

I didn't know to name this issue xd but basically instead of importing types in each file, use the part and part of keywords. You can have a look there and there.

I find the name Urls for the enum is not adapted.
I think it should be renamed to casUrl.

Also, the Client would be different:

class Client {
  final casUrl _url;
  late String token;
  Map<String, String> header = {};
  late UserInfo info;

  String get url => _enumToUrl(_url);

  Client(this._url, username, password) {
    login(username, password);
  }

  ///Create this object if you already have a token
  Client.fromToken(this.token, this._url) {
    header.addAll({'X-Kdecole-Auth': token, 'X-Kdecole-Vers': '3.7.14'});
  }
...

What do you think about it @Freezman31?

For example at

Email({required this._title, required this._body, required this._sender, required this._receivers, required this._id, required this._messages}); 

Also, what is the interest of using private attributes along getters there @Freezman31?