Giter VIP home page Giter VIP logo

evcontactspicker's People

Contributors

andrewnlauder avatar edwardvalentini avatar haritonbatkov avatar pahmed avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

evcontactspicker's Issues

Swift 4

Hi!, we've been using this Pod for a while now and we are now migrating our project to swift 4 and we are having issues migrating this particular Pod (Mainly because of the Nuke v4.1.2 dependency)

So we wanted to know if there's an upcomming migration to swift 4. I noted there's a commit regarding support for swift 3.2 & 4 but the readme still says swift 3 and I cannot build the project for swift 4.

Cheers!

Crashes on Refresh of Contacts

Hello I seem to have fixed a bug that was troubling me for the past few weeks.

On iPhone 6 with test contacts the bug did not show but only on iPhone 7 Plus with real (my personal) contact list did it occur.

I was able to fix it by updating the following code:

https://github.com/edwardvalentini/EVContactsPicker/blob/master/Pod/Classes/EVContactsPickerViewController.swift#L279

if(tmpContact.imageDataAvailable) {
                        if let imgData = tmpContact.imageData {
                            let img = UIImage(data: imgData)
                            mutableContact.image = img
                        } else {
                            mutableContact.image = self.avatarImage
                        }
                    } else {
                        mutableContact.image = self.avatarImage
                    }

Basically we should check if their is data similar to how same as it is done above (https://github.com/edwardvalentini/EVContactsPicker/blob/master/Pod/Classes/EVContactsPickerViewController.swift#L224)

Passing prior selected contacts

Is it possible to pass in a object with the previous selected contacts? This way you can keep the state to allow user to edit and not start over again. If not this would be great feature.

Thanks for the awesome framework, hope I can contribute some more after holidays.

Crash Onload of Example

Tried the example but it just crashes with this message:

Works on Simulator but not Actual Device.

AddressSanitizer debugger support is active. Memory error breakpoint has been installed and you can now use the 'memory history' command.
hh is Optional("Add Contacts")
2016-12-05 19:11:02.812946 EVContactsPicker_Example[1329:370951] [LayoutConstraints] Unable to simultaneously satisfy constraints.
	Probably at least one of the constraints in the following list is one you don't want. 
	Try this: 
		(1) look at each constraint and try to figure out which you don't expect; 
		(2) find the code that added the unwanted constraint or constraints and fix it. 
(
    "<NSLayoutConstraint:0x104e1e1d0 UITextView:0x106201c80'No Contacts Selected.'.leading == UIView:0x105811e40.leadingMargin + 84   (active)>",
    "<NSLayoutConstraint:0x104e1e160 UIView:0x105811e40.trailingMargin == UITextView:0x106201c80'No Contacts Selected.'.trailing + 77   (active)>",
    "<NSLayoutConstraint:0x104e1e0f0 UITextView:0x106201c80'No Contacts Selected.'.centerX == UIView:0x105811e40.centerX   (active)>"
)

Will attempt to recover by breaking constraint 
<NSLayoutConstraint:0x104e1e160 UIView:0x105811e40.trailingMargin == UITextView:0x106201c80'No Contacts Selected.'.trailing + 77   (active)>

Make a symbolic breakpoint at UIViewAlertForUnsatisfiableConstraints to catch this in the debugger.
The methods in the UIConstraintBasedLayoutDebugging category on UIView listed in <UIKit/UIView.h> may also be helpful.
fatal error: unexpectedly found nil while unwrapping an Optional value
2016-12-05 19:19:53.898333 EVContactsPicker_Example[1329:370951] fatal error: unexpectedly found nil while unwrapping an Optional value

Memory Leak

There's a memory due to un-weak delegate.
In EVContactsPickerViewController at line 43: public var delegate : EVContactsPickerDelegate?
such deletgate need to be weak by letting EVContactsPickerDelegate extends class.

Leak can be verified in Profile.

Please fix.
Thanks

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.