eerkaijun / private-accounts Goto Github PK

Currently, the frontend maps 1 public account to 1 private account. We would like to support one-to-many such that each private account can be used for a different purpose. Refer to README.md.

It would be useful to define invariant properties of the smart contracts and test them.

Currently in the smart contracts scripts directory (https://github.com/eerkaijun/private-accounts/tree/main/contracts/scripts), there is the bundler.ts and paymaster.ts scripts which uses test networks (e.g. goerli and linea goerli) to run the integration tests. It would be nice to run these integration tests in a local environment for easier testing. This will mean that we also need to setup a bundler locally and connect the bundler to a local full node. Then, we can send requests to this bundler.

Best to have unit tests for circuits. A useful library for that: https://github.com/weijiekoh/circom-helper

Refer to: https://github.com/eerkaijun/private-accounts/blob/main/contracts/contracts/PrivatePaymaster.sol#L62

Since we use a multi asset shielded pool, we need an oracle to get the price of the assets, in order to deduct during withdrawal from the shielded pool.

Is it necessary to implement our own relayer network for private transfers? If so, what are the building blocks or existing implementations?