effect-deprecated / otel Goto Github PK

Currently @effect-ts/otel only support @effect-ts/core/Effect code but should also support code written with @effect-ts/core/Effect/Stream.

Additionally to setting the error attributes here we should also set the span status accordingly like the following:

          if (e._tag === "Failure") {
            s.setAttribute("error.type", "Fiber Failure")
            s.setAttribute("error.message", "An Effect Has A Failure")
            s.setAttribute("error.stack", pretty(e.cause))
            s.setStatus({ code: 2 })
          } else {
            s.setStatus({ code: 1 })
          }

(Should probably use the SpanStatusCode enum directly instead of hard-coding the number value)

More info: https://opentelemetry-python.readthedocs.io/en/latest/api/trace.status.html#module-opentelemetry.trace.status

In order to reduce the performance overhead of tracing (particularly when using slower operations such as JSON.stringify) we should explore making it possible to defer the execution of some operations where possible (e.g. span attribute processing).

See https://github.com/astoilkov/main-thread-scheduling

    return T.bracketExit_(
      createSpan,
      (s) => pipe(effect, T.provideService(Span)(new SpanImpl(s))),
      (s, e) =>
        T.succeedWith(() => {
          if (e._tag === "Failure") {
            s.setAttribute("error.type", "Fiber Failure")
            s.setAttribute("error.message", "An Effect Has A Failure")
            s.setAttribute("error.stack", pretty(e.cause))
            s.setStatus({ code: OTApi.SpanStatusCode.ERROR })
            // ^^^^^^^^^^^^^^^^^^^
          } else {
            s.setStatus({ code: OTApi.SpanStatusCode.OK })
          }
          s.end()
        })
    )

Differentiate here between interruption due to an error or "voluntary" interruptions

Currently Otel-related calls are included in the Effect stack tracing which doesn't really add much value and makes stack traces less readable. This should be disabled.

Currently @effect-ts/otel only support @effect-ts/core/Effect code but should also support code written with @effect-ts/core/Sync.

open-telemetry/opentelemetry-js#987 (comment)

• Should auto-regenerate yarn.lock after releasing new version
  • Currently yarn version:* commits & pushes some code without refreshing the yarn.lock file leading to the release failing in GH actions
• Enable single tsc --build --watch for entire project as VSC task
  • Requires TS option incremental and composite set to true
• Move package specific devDependencies from root package.json to specific package/my-pkg/package.json
• Enable test watching
• Consolidate configs across projects (Jest, eslint, tsconfig, ...)
• Use changesets for releases/changelogs
• Migrate to yarn 3 (in other repos)
• Emit only once from TS ES2018+ and use esbuild for the commonjs output