efprefix / efautoscrolllabel Goto Github PK

View Code? Open in Web Editor NEW

124.0 4.0 16.0 5.81 MB

A label which can scroll when text length beyond the width of label.

Home Page: https://swiftpackageindex.com/EFPrefix/EFAutoScrollLabel

License: MIT License

Ruby 4.33% Swift 94.81% Shell 0.86%

swift uilabel autoscrolllabel cocoapods ios

efautoscrolllabel's Issues

XCode Warning: 'characters' is deprecated: Please use String or Substring directly

As of XCode 9.1, the following warning is issued:

'characters' is deprecated: Please use String or Substring directly -> EFTAutoScrollLabel.swift

XCode: 9.4
EFAutoScrollLabel: 4.0.2
Swift: 3.3

It would be great to take care of this to reduce the warnings in the build log. It is a very simple fix, I can submit a PR if you would like.

Thanks!

UI API called on a background thread

After few ten seconds it stops to scroll and XCode says UI API called on a background thread: (the log below), also XCode highilghts these 3 issues. How to heal it? I put the func to DispatchQueue.main.async, it works, but don't think it is good.

ps. thanks for your work!

Main Thread Checker: UI API called on a background thread: -[UILabel text]
PID: 2019, TID: 3478103, Thread name: (none), Queue name: com.apple.root.default-qos.overcommit, QoS: 21
Backtrace:
4   MyApp!                          0x0000000100672f48 _T010MyAppO_17EFAutoScrollLabelC4textSSSgfg + 132
5   MyApp!                          0x0000000100676d08 _T010MyAppO_17EFAutoScrollLabelC06scrollE8IfNeededyyF + 84
6   MyApp!                          0x0000000100677f08 _T010MyAppO_17EFAutoScrollLabelC06scrollE8IfNeededyyFTo + 40
7   Foundation                          0x0000000187f93860 <redacted+ 996
8   libsystem_pthread.dylib             0x00000001871d032c <redacted+ 308
9   libsystem_pthread.dylib             0x00000001871d01f8 <redacted+ 0
10  libsystem_pthread.dylib             0x00000001871cec38 thread_start + 4

Main Thread Checker: UI API called on a background thread: -[UIView bounds]
PID: 2019, TID: 3478103, Thread name: (none), Queue name: com.apple.root.default-qos.overcommit, QoS: 21
Backtrace:
4   MyApp!                          0x0000000100676fb4 _T010MyAppO_17EFAutoScrollLabelC06scrollE8IfNeededyyF + 768
5   MyApp!                          0x0000000100677f08 _T010MyAppO_17EFAutoScrollLabelC06scrollE8IfNeededyyFTo + 40
6   Foundation                          0x0000000187f93860 <redacted+ 996
7   libsystem_pthread.dylib             0x00000001871d032c <redacted+ 308
8   libsystem_pthread.dylib             0x00000001871d01f8 <redacted+ 0
9   libsystem_pthread.dylib             0x00000001871cec38 thread_start + 4

Main Thread Checker: UI API called on a background thread: -[UIView layer]
PID: 2019, TID: 3478103, Thread name: (none), Queue name: com.apple.root.default-qos.overcommit, QoS: 21
Backtrace:
4   MyApp!                          0x0000000100677434 _T010MyAppO_17EFAutoScrollLabelC06scrollE8IfNeededyyF + 1920
5   MyApp!                          0x0000000100677f08 _T010MyAppO_17EFAutoScrollLabelC06scrollE8IfNeededyyFTo + 40
6   Foundation                          0x0000000187f93860 <redacted+ 996
7   libsystem_pthread.dylib             0x00000001871d032c <redacted+ 308
8   libsystem_pthread.dylib             0x00000001871d01f8 <redacted+ 0
9   libsystem_pthread.dylib             0x00000001871cec38 thread_start + 4

Main Thread Checker: UI API called on a background thread: -[UIScrollView setContentOffset:]
PID: 2019, TID: 3478103, Thread name: (none), Queue name: com.apple.root.default-qos.overcommit, QoS: 21
Backtrace:
4   MyApp!                          0x0000000100677620 _T010MyAppO_17EFAutoScrollLabelC06scrollE8IfNeededyyF + 2412
5   MyApp!                          0x0000000100677f08 _T010MyAppO_17EFAutoScrollLabelC06scrollE8IfNeededyyFTo + 40
6   Foundation                          0x0000000187f93860 <redacted+ 996
7   libsystem_pthread.dylib             0x00000001871d032c <redacted+ 308
8   libsystem_pthread.dylib             0x00000001871d01f8 <redacted+ 0
9   libsystem_pthread.dylib             0x00000001871cec38 thread_start + 4

scroll is unused

add the label to UITabelViewCell,label can`t scroll

Main Thread Checker: UI API called on a background thread:

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

I have read the README.md, but there is no information I need.
I have searched in existing issues, but did find a same one.

Issue Description

The error appears.

Main Thread Checker: UI API called on a background thread: -[UILabel text]
PID: 6718, TID: 54018, Thread name: (none), Queue name: com.apple.root.default-qos.overcommit, QoS: 21

Description

It causes by this code.

    @objc public func scrollLabelIfNeeded() {
        if text == nil || text?.isEmpty == true {
            return
        }

        DispatchQueue.main.async { [weak self] in
            guard let self = self else { return }
            self.scrollLabelIfNeededAction()
        }
    }

Reproduce

I've got it by adding label to UIPickerView as custom view. If I do nothing for about 10 seconds the error appears.

Other Comment

This code fixed it.

    @objc public func scrollLabelIfNeeded() {
        DispatchQueue.main.async { [weak self] in
            guard let self = self else { return }
            if self.text == nil || self.text?.isEmpty == true {
                return
            }
            self.scrollLabelIfNeededAction()
        }
    }

Count times label scrolled?

Is there currently any way to put a count on the number of times the label will scroll?

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.