Giter VIP home page Giter VIP logo

competitive-mahjong's Introduction

competitive-mahjong

Some sort of mahjong client. Hand evaluation, board representation, client itself. Hand evaluation works pretty well. The representation has not been put together but has a lot of parts. The client itself has no progress yet.

competitive-mahjong's People

Contributors

eirikulversoy avatar

Watchers

James Cloos avatar  avatar

competitive-mahjong's Issues

Different possibilites differentation

Pointing out the possible combinations with colored lines between them. 2345 would have one color for 234 and one color for 345 if 4 or 3 was clicked. If the tile is 2 or 5 it should only show one combination. The amount of possible combinations and actual combinations can be listed as a number below the tiles.

No char images

Bamboo tiles are being used instead of character ones. This might get fixed when redoing the other classes.

Tests for Visual module

Need to follow a tutorial for javafx testing.
Parts that do not need this can still be done.

Redesign

The way HandEvaluator, HandIdentifier and the Valuation classes are put together is really messy. I like HandIdentifier but HandEvaluator is just a collection of random helper functions.

Redesign han evaluation

Should be moved to different classes, the han evaluation class should have finding the han value as its responsibility, maybe through a han map from hand to han/points. All the hand filtering functions should be in another class.

Better classes etc

Patterns, inheritance, other stuff that looks better than the current class setup

Tests for Evaluation

Doublechecking the already done classes.
Add tests for:
ValuationFu

The other classes are too unfinished for now.

Visual/GUI/Client

Anything to start really, nothing here yet. Anything/Everything in the visualization module can be scrapped.

Set highlighting

When clicking a tile that has a three of a kind combination, they should be highlighted(lifted). Should handle KANs as well.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.