ekocibar / javascript1 Goto Github PK

https://github.com/pesh12/ENES-JS/blob/master/Week%200%20~%20canI.js

if(differentTypes[4] = true) will always be true!!!
Only == checks, = just assigns one to the other.

Did you come up with both methods of comparing arrays yourself?

1. give it a better name like :addPicturesToList
2. Pass the list/array as a parameter to the function
3. ...
4. Profit!

console.log(3 === 3 ? "true" : "false");
lik ethis

https://github.com/pesh12/ENES-JS/blob/master/Week%200%20~%20sameType.js

Look up the difference and try using just an array.

Now you're looping through the entire second objects list of keys for every key in obj1.

This is a lot more readable

let differentTypes = [ 1, 'Hello', 2, 'World', true];
if(differentTypes[4] = true) 
{
   console.log( 'Yes, we can store different types in a single array' + differentTypes[1] + differentTypes[3])
}

https://github.com/pesh12/Javascript1/blob/cc41a99136c5b32ff99305b8ad99c381651eccc5/Week3/allTogetger.js#L61

🏅

One file per week is fine for now ;)

If you pass a number (index) to the function for your list, you can get the right list item like so list[number]. This will only work for arrays btw.

https://github.com/pesh12/ENES-JS/blob/master/Week1/0%20allTogether.js#L20

Why are you passing an assignment of "a=" to the function? That' a bit confusing and unnecessary.

https://github.com/pesh12/Javascript1/blob/cc41a99136c5b32ff99305b8ad99c381651eccc5/Week3/allTogetger.js#L41

A ul should ONLY have lis inside it. not loose text.

Please describe below how you got this idea.

https://github.com/pesh12/Javascript1/blob/cc41a99136c5b32ff99305b8ad99c381651eccc5/Week3/allTogetger.js#L123

So the function already works really well. I like how you add headings to each book.
First thing that could be better is adding the lis to a list. Theyre list elements after all so adding them to the body doesnt make sense, give them an ul parent.
Second: What could be better is the variable names. instead of item1 for instance, write liElement.
Third: Try giving the newlist a parameter, and have that parameter be the list of books. That way you could also pass it another list of books and it would still work!

By putting let list = inside the function, it will run everytime you call the function. You should define the list outside the function so it's only created once.