Comments (5)
cc @elastic/apm
from apm-agent-nodejs.
What I would expect:
- Everything merged into master will show up in the master docs. The "master" branch is not the one that is installed through
npm install elastic-apm-node
. More something likenpm install --branch=master elastic-apm-node
(or what option exists there in npm ...). npm install elastic-apm-node
installs the most recent release tag. I assume there is an option innpm
that a version can be specified.
The above I think would resemble what the rest of the stack does.
from apm-agent-nodejs.
@ruflin npm doesn't install directly from github by default (it's possible, but normally not recommended). Instead packages are downloaded from the central npm registry as tar-balls. They are uploaded by the developer once the developer cut a release. So a release is basically the developer making a new commit which bumps the version number and then uploads a tar-ball to the the registry containing whatever files was in his local directory at the time the tar-ball was created.
As a developer I can make this release commit in any branch. Most projects do this in the master branch. But if a project needs to support making patch releases for older releases, they tend to have branches for each major release in which the developer will make and push these release commits that bumps the version. But this is usually just there to benefit the developer. The user of the module will still just install it from the npm registry as any other version without knowing anything about, nor specifying a git branch, commit, or tag.
(In case you're interested, to install from master - or any other git ref for that matter - you'd write npm install <github-user>/<repo>[#<ref>]
)
TL;DR:
My point is that we're free to choose a branch strategy without considering how people are installing the module. Instead I think we should optimize of how easy it is to us manage and work with every day, as long as it lives up to our minimum requirements: E.g. can we display the docs how we want + does it allow us to make the releases that we need.
from apm-agent-nodejs.
A single branch rather than a branch per major is probably enough for now. I wouldn't expect us to need to do a lot of backporting. We can always reevaluate that in the future.
from apm-agent-nodejs.
We since decided to have branches for each major version. That solves this issue, so I'll close for now
from apm-agent-nodejs.
Related Issues (20)
- elastic-apm-node not working for mongoose 8.0.3 and mongodb 6.2.0 HOT 1
- support `node --enable-source-maps` usage with our custom `Error.prepareStackTrace` usage
- fix <database>.$cmd.getMore span on mongodb
- Memory usage reported incorrectly in k8s pod HOT 3
- Support of Next js ^14 HOT 2
- `_signalLambdaEnd` request to Lambda extension should set `Content-Type`
- Questions re ESM support for MikroOrm / knex, Node v20, & OIDC HOT 3
- Unhandled ERR_INVALID_URL causing node.js service to exit HOT 1
- question: applying user.id when using opentelemetry api with Elastic HOT 2
- remove opentracing doc
- issue labeler workflow failing HOT 7
- Support mtls connection
- test issue to see if labeler action works on an issue HOT 1
- edge "test-nightly" failing after kafka/zookeeper addition
- TAV failing for `[email protected]` HOT 4
- Agent doesn't capture uncaught exceptions or unhandled rejections HOT 11
- Request body is logged even with `captureBody: off` HOT 17
- undici instrumentation can add duplicate trace-context headers, which can break Elasticsearch HOT 2
- release fails in make-distribution.sh step
- KafkaJS instrumentation throw exception on "tombstone message" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apm-agent-nodejs.