Simplify IndexAsync Abstraction to Infer Index Name from TDocument Type about elasticsearch-net HOT 3 CLOSED

The values that guided the choice make sense to me.

A default index is not a thing that we're interested in. We're looking for a more dynamic approach. But thanks anyway.

👍

By the way, once we have an implicit operator from IndexName and Id to string, we no longer need the overload with string; it's not gonna work anyway:

I would rather say it works too good 😄 Both IndexName and Id have implicit conversion operators from string. This unfortunately causes an ambiguity for which I have not yet decided how to solve it.

As a workaround you can either cast to e.g. IndexName like you did above, or specify the argument name explicitly:

=> client.IndexAsync(document, index: "index-name", token);

from elasticsearch-net.

Hi @AntonioFalcaoJr,

thanks for the feature request. What version of the Elasticsearch client are you currently using? I'm asking because there already is an IndexAsync overload in the ElasticsearchClient that supports index name inference:

public virtual Task<IndexResponse> IndexAsync<TDocument>(TDocument document, CancellationToken cancellationToken = default)

To use this method, you must specify the desired default index during initialization like this:

var settings = new ElasticsearchClientSettings(new Uri("https://..."))
	.Authentication(new BasicAuthentication("elastic", "..."))
	.DefaultMappingFor<Person>(x => x.IndexName("person")); // <- Set default index for 'Person'

var client = new ElasticsearchClient(settings);

await client.IndexAsync(new Person());

The implicit derivation of a lowercase index name from a specific type is problematic. We try to follow the principle of "explicit before implicit" to avoid as many surprises as possible. Not everyone uses an index name that is simply a lowercase representation of the entity name. Also, sometimes the same entity is stored in different indexes. For this reason, we want the user to explicitly configure the default index once during initialization.

Please let me know if that works for you 🙂

from elasticsearch-net.

I'm using version 8.13.12.

The values that guided the choice make sense to me.

A default index is not a thing that we're interested in. We're looking for a more dynamic approach. But thanks anyway.

By the way, once we have an implicit operator from IndexName and Id to string, we no longer need the overload with string; it's not gonna work anyway:

from elasticsearch-net.