Comments (5)
Here's a repo (xunit):
[InlineData(10000)]
[InlineData(long.MaxValue)]
public async Task Should_get_index_with_mapping_nested_fields_limit_set_to_maximum(long limit)
{
// Arrange
var indexName = $"{Guid.NewGuid():N}";
var client = TestElasticsearchClientFactory.Instance; // returns an ElasticsearchClient instance
try
{
var descriptor = new CreateIndexRequestDescriptor(indexName);
descriptor.Settings(s => s.OtherSettings(sd => sd.Add("index.mapping.nested_fields.limit", limit.ToString())));
var createIndexResponse = await client.Indices.CreateAsync(descriptor);
createIndexResponse.ThrowIfInvalid();
// Act
var index = await client.Indices.GetAsync(indexName);
// Assert
var indexState = index.Indices.Should().ContainSingle().Which.Value;
var limitRetrievedFromSettings = indexState.Settings?.Index?.Mapping?.NestedFields?.Limit;
limitRetrievedFromSettings.Should().Be((int)limit); // TODO: fix assertions
}
finally
{
try
{
await client.Indices.DeleteAsync(indexName);
}
catch
{
// ignored
}
}
}
works with 10000, but doesn't work with long.MaxValue
. In both cases, the server returns the property in question as a string.
from elasticsearch-net.
Hi @cguedel, thank yo for the reproducer 🙂
It seems like the type of limit
is incorrectly modelled as int
instead of long
in our specification.
from elasticsearch-net.
@flobernd Are you sure this is fixed? From my repro it still fails and from https://github.com/elastic/elasticsearch-net/blob/main/src/Elastic.Clients.Elasticsearch/_Generated/Types/IndexManagement/MappingLimitSettingsNestedObjects.g.cs#L36 it looks like this is still an int
and not a long
from elasticsearch-net.
@cguedel Yes, I noticed as well. Something went wrong when generating the new client. The preprocessing of the specification was not completed. I'll push a follow up fix soon.
from elasticsearch-net.
Confirm that this is fixed in 8.13.15, thanks for the quick response!
from elasticsearch-net.
Related Issues (20)
- Migration issues Templates and Dynamic queries HOT 5
- Client cannot deserialize string to list of strings HOT 4
- [Feature] Elastic 8 - MatchAll won't accept passing nothing HOT 1
- Creating a local stack s3 repository failed. use Postman works, but code calls are not working.
- [FEATURE] Elastic 8 Client - Stores Enums as Strings HOT 5
- Cannot use RawJsonQuery HOT 6
- Encountered an unsupported variant tag '' on 'Analysis.INormalizer', which could not be deserialized
- Simplify IndexAsync Abstraction to Infer Index Name from TDocument Type HOT 3
- Lacks the ability to put aggregations into aggregations HOT 5
- Elasticsearch 8.13 documentation not available when NuGet update is available HOT 1
- Deserializing type hierarchies doesn't seem to work HOT 10
- Update index settings with PutSettingsAsync fails with error status code 400: "request body is required" HOT 1
- Cannot retrieve mapping of index with `icu_collation_keyword` field HOT 6
- cannot instantiate new DynamicTemplate when creating index. HOT 4
- Default index is not used in query with 8.13.15 client HOT 1
- Missing properties in aggregation API HOT 3
- Improve documentation for error handling
- Elastic.Transport.UnexpectedTransportException when calling elasticClient.MachineLearning.InferTrainedModelAsync HOT 1
- Support for using input_output option in inference processor
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elasticsearch-net.