Giter VIP home page Giter VIP logo

sitri's People

Contributors

aiovlev avatar dependabot[bot] avatar egnod avatar github-actions[bot] avatar gitter-badger avatar sudoguy avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

sitri's Issues

Vault provider: validation errors

Hi there!

I have a problem with using the Vault provider:

provider_config.py:

import hvac

from sitri.providers.contrib.vault import VaultKVConfigProvider
from sitri.settings.contrib.vault import VaultKVSettings
from sitri.providers.contrib.system import SystemConfigProvider


configurator = SystemConfigProvider()
ENV = configurator.get("ENV")

is_local_mode = ENV == "local"
local_mode_file_path = configurator.get("LOCAL_MODE_FILE_PATH")


def vault_client_factory() -> hvac.Client:
    """
    vault-provider
    :return: connected vault-client
    """
    client = hvac.Client(url=configurator.get("VAULT_URL"), verify=False)
    jwt_token_file = open('/run/secrets/kubernetes.io/serviceaccount/token')
    jwt = jwt_token_file.read()

    role = str(configurator.get("NAMESPACE")).lower()
    cluster = str(configurator.get("CLUSTERNAME")).lower()

    # Auth
    client.auth_kubernetes(
        role=role,
        jwt=jwt,
        mount_point=f'kubernetes/{cluster}',
    )

    client.is_authenticated()
    return client


provider = VaultKVConfigProvider(
    vault_connector=vault_client_factory,
    mount_point=f"{configurator.get('VAULT_PATH')}/{ENV}",
)


class BaseConfig(VaultKVSettings.VaultKVSettingsConfig):
    provider = provider
    local_mode = is_local_mode
    local_provider_args = {"json_path": local_mode_file_path}

app_settings.py

from pydantic import BaseSettings, Field
from src.core.config.database_settings import DBSettings

class AppSettings(BaseSettings):
    db: DBSettings = Field(default_factory=DBSettings)

database_settings.py

from typing import Optional
from pydantic import Field
from sitri.settings.contrib.vault import VaultKVSettings

from src.core.config.provider_config import provider, BaseConfig


class DBSettings(VaultKVSettings):
    user: str = Field(...)
    password: str = Field(...)
    host: str = Field(...)
    port: int = Field(...)
    db_name: str = Field(...)
    sqlalchemy_db_url: Optional[str] = None

    def __init__(self, **data):
        super(DBSettings, self).__init__(**data)
        self.sqlalchemy_db_url = f"postgresql://{self.user}:{self.password}@{self.host}:{self.port}/{self.db_name}"

    class Config(BaseConfig):
        provider = provider
        default_secret_path = "db"
        local_mode_path_prefix = "db"

When I run my app, I get the following errors:

File "/home/casper/PythonProjects/s7/emc/catalog/api_service/src/core/config/database_settings.py", line 19, in __init__
    super(DBSettings, self).__init__(**data)
  File "pydantic/env_settings.py", line 36, in pydantic.env_settings.BaseSettings.__init__
  File "pydantic/main.py", line 406, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 5 validation errors for DBSettings
user
  none is not an allowed value (type=type_error.none.not_allowed)
password
  none is not an allowed value (type=type_error.none.not_allowed)
host
  none is not an allowed value (type=type_error.none.not_allowed)
port
  none is not an allowed value (type=type_error.none.not_allowed)
db_name
  none is not an allowed value (type=type_error.none.not_allowed)

I thin the problem is here:
sitri/providers/contrib/vault/vault_kv.py

def get(
        self, key: str, mount_point: typing.Optional[str] = None, secret_path: typing.Optional[str] = None, **kwargs
    ) -> typing.Optional[str]:
        request_params = {
            "path": secret_path if secret_path else self._secret_path,
            "mount_point": mount_point if mount_point else self._mount_point,
        }
        # current
        response = self._vault.secrets.kv.v1.read_secret(**request_params)
        # should be
        response = self._vault.secrets.kv.v1.read_secret(**request_params)["data"]

        return response["data"].get(key)

response in current realization has:

{
  'request_id': '3558dd81-41ae-8cbc-2ebc-ef4ec6508671', 
  'lease_id': '', 
  'renewable': False, 
  'lease_duration': 0, 
  'data': {
    'data': {
      'db_name': 'epaas_emc-ctlg-api_t', 
      'host': 'pg-epaas_emc-ctlg-api_t', 
      'password': '1q2w2e3e', 
      'port': '8432', 
      'user': 'owner'
    }, 'metadata': {
      'created_time': '2021-06-26T17:31:26.824506368Z', 
      'deletion_time': '', 
      'destroyed': False, 
      'version': 1
    }
  }, 
  'wrap_info': None, 
  'warnings': None,
  'auth': None
}

and response["data"] return:

'data': {
      'db_name': 'epaas_emc-ctlg-api_t', 
      'host': 'pg-epaas_emc-ctlg-api_t', 
      'password': '1q2w2e3e', 
      'port': '8432', 
      'user': 'owner'
    }, 'metadata': {
      'created_time': '2021-06-26T17:31:26.824506368Z', 
      'deletion_time': '', 
      'destroyed': False, 
      'version': 1
    }

Could you please resolve this issue?

thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.