electerious / basicgrid Goto Github PK

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Columns with small-offset-x and large-offset-0 or medium-offset-0 don't seem to work. The zeroed out offsets (if set to greater than zero it functions as expected) just inherit the value of the small-offset-x for the larger breakpoints. This seems to be because of the way the margin-left value is calculated as a percentage.

Adding this as an override for those two classes specifically seems to fix the issue: Never mind this seems to override the small offset at the small size. :(

.large-offset-0, .medium-offset-0 {
	margin-left: 0 !important;
}

Using flexbox with "float as fallback"

When using hide-on and show-on to change the visibility of an element set to display: flex; it seems to override the existing display mode and set it to block which is undesired. Setting show-on to display: inherit seems to have fixed this for me but I don't feel confident enough in my CSS skills to just go and submit a PR for this issue!

Would appreciate it if somebody a little more knowledgeable wouldn't mind testing this ;P

Hi @electerious ,

I love basicGrid and have been using it on all of my projects lately. 🙌 Excellent work!

Do you know if basicGrid is hosted on a CDN anywhere? I have been bundling it in with my sites for now (see themer.mjswensen.com) but would love to reference a CDN-hosted copy if available.

Keep up the great work!

Hi Tobias,

I am getting a lot of warnings while using your grid.
Maybe it is time to rework it.

Docs:
https://sass-lang.com/documentation/breaking-changes/slash-div

For example:

margin: 0 $basicGrid__gutter/-2;

Should become:

@use "sass:math";
margin: 0 math.div($basicGrid--gutter, -2);

Hope it helps.

S

Hi guys, how are you? First of all, awesome lib!

Following the concept of foundation's grid, on .row you need to add margin negative on left and right.

Foundation adds a css class to "clear" these margins, take a look on this basic example:

.row {
  margin-left: -.9rem;
  margin-right: -.9rem;

  &.column {
    margin-left: 0;
    margin-right: 0;
  }
}

What do you think? Thanks!