elenaparaschiv / libraries-out-of-order Goto Github PK

Code style

• Inconsistent spacing in comments (L7, L15, L23), after control statements (L4, L6, L8, L16), etc.
• Inconsistent indentation (L18, L21).
• Use Airbnb's style guide for a consistent coding style.

Code reuse

• Reuse previously declared variables where it aids readibility (L25 can be reused in L26, L27).

Concise tests

• L50, L64, L78 are unnecessary since they don't contribute to the tests. L91, L92, L93, on the other hand, are useful (you could further clean this last test by keeping only what is necessary).
• Why use a cryptic var name when the more clear version is just 4 more chars? (L83).

Missing test

• There's no test to check if the function throws TypeError under right conditions (for L19).

Great job! Your logic behind the function is sound! 👍