hyf-javascript1's People
hyf-javascript1's Issues
Theres a syntax error on line 32
hint: //
Dont ave js files as txt
Then you can't run them as js ;)
Just save as .js
Also please dont use spaces in the file name, this will cause some issues later on.
You can write filenames like thisIsMyFile.js
Don't use alert instead of console
It only works in the browser and we're working in Node. In the browser its also better to use the console.
it is better to have a shorter id
https://github.com/Elias011/elias.js/blob/abd1daee86c79d2e95b1644f7c387679bd2d6f06/week3/jhf.js#L88
This will work but it is better practice to have a shorter id. an example could be using i + '_img'
. That way it is guaranteed to have the id
unique and short. Same applicable for the rest of IDs
Repository name
Hi elias please give your repository a proper name.
Call it hyf-javascript1 or something, now it does not say anything about what is inside...
This makes it harder for your teachers and fellow students to find the correct files when they want to give you feedback!
Lol where did you get the idea to use h0!
You're thinking like a programmer, sadly html wasnt built by programmers so you have to start with h1 ;)
Nice work Elias
I have some notes :
1- you used a tag "h0" to display the title of the page,it is not a standard html element, so you can use "p,div,.." instead of it
2- it is not necessary to set the id of the elements if you do not use it, and the id usually is a unique string value with alphabetic and numeric characters, so it is not standard to set :
<img id="image/aleph.jpg">
<h2 id="Author: Paulo-Coelho <br>">
<h3 id="Language: Portuguese">
(the first book in the page)
3- you included the images of the books in the books object ("info"),that is good in the practical situation, but our task was to create a new object "images_object" that contains the images of the book,then you should search in the DOM to find every book by id and append a image to it, the image takes its source "src" from "images_object"
No need for empty return in the end
Did you check if your code works? Because some of it doesnt
This will cause a syntax error. Find out why and fix it.
let x = 7.25;
math.round(x);
define a list not an object
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.