elmira202003 / hyf-javascript1 Goto Github PK

Hi Elmira, here is my feedback on your homework.

I suspect that your VSCode setup does not completely match what we tried to set up during the lecture. Can you please check the VSCode Tips and verify the settings for "editor.formatOnType" and ""editor.formatOnPaste"?

Also, make sure that you create an .eslintrc.json file in the root folder of your repo. Again, see VSCode Tips.

For readability of your code, it would be nice to separate the exercises with a blank line, similar what you would do when you write a piece of text: you would probably separate paragraphs with a blank line.

no.5 exercise

• There is another way to determine the highest value of two numbers. Google for 'mdn math' and see what you can find.
• If you use an if statement it is a best practice to start a new line after an opening curly brace and indent the content within the braces:

if (z > a) { 
  console.log(z); 
} else { 
  console.log(a); 
}

no.6 exercise

If you want to split the initialisation values of an array across multiple lines it is best practice to start a new line after the opening square bracket:

pets = [
  'dog',
  'cat',
  'sheep',
  'hen',
  'chicken',
  'horse'
];

no.8 exercise

• Use the triple form === in preference over ==.
• Formatting of if statements, see above.

no.10 exercise

• if statement formatting

As you can see, my comments are mainly about formatting. Functionality-wise your code is 100% correct and I didn't see any spelling errors. Well done!
thank you for your great comments teacher. I do them .

Dear Beauty, you have been doing fantastic job he, you have done great work , I have been implemented your code, there are really neat and comprehensible,especially you have been using this syntax right place ( condition ? expr1: expr2 ), now I have realized that I have been rarely using this syntax, again really appreciate your homework.