There is places where I catch it instead of if (object != null) which can save a lot of code and replications.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
No

Describe the solution you'd like
A clear and concise description of what you want to happen.
A new form/ window openable in the Settings Form/Window that:

• Lists plugins in plugin sources.
• Allows for the user to install them using the configured install methods.
  And change the settings form/Window to:
• Add option to add plugin source repository urls that contains it’s own list of plugins to install.
• Add option to enable installing plugins to a zip file (Create Plugins.zip instead of creating "Plugins\" subfolder after installing the first plugin.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Nothing else yet really.

Additional context
Add any other context or screenshots about the feature request here.
Basically I am thinking of making instaling plugins as simple as lookup of them and list them in gui similar to apt on linux commandline to install packages, or even nuget for that matter.

Pro: Easier to install plugins.
Con: Plugin could target a framework or dependency not on the system (like .NET Core or nuget packages)
Con: Adds another control to the Core dll.

I think because of this con the lookup should have a list of dependencies to install first then prompt the user to install that framework, or nuget package first before installing the plugin. But I see this of more a challenge than good. The other possible way is have the developer load their dependencies as an embedded resource which would rectify our problems (excluding their target framework assemblies).

Issue Description

After setting the path to my elsword folder it will give me an unhandled exception
if i just run the kom extractor by itself then it gives me this error

and if i run the kom re-packer it gives me that error

Debug information

• Els_kom version: 1.4.9.8
• OS: Windows 10 Pro Version 1607
• OS Arch: x64
• OS Build: 14393.1944

I think the plugins should either use the version set in the SharedVersionInfo.cs file, move them to another repository, or both.

Personally having them in a separate repository and have some sort of plugin installer which takes the url of a github repository and download the latest availible release / pre-releases might be an option. That way plugin specific code cannot be blocking releases any longer. The downside is that removing or renaming or changing function paramiters the plugins use could make the program crash because the plugin crashed (if they even can be compiled then ofc).

And then any closed sourced plugins could have their sources under externals/ or whereever where git could then ignore them from this repositiry and any possible security related code or files they may contain. As such I see this as more of a win for everyone involved.

Issue Description

image

Severity Code Description Project File Line Suppression State
Error MSB3073 The command "echo F|xcopy /Y /c C:\Users\Noo\Documents\Els_kom_new-master\PCbuild..\etc\pyconfig.h C:\Users\Noo\Documents\Els_kom_new-master\PCbuild..\externals\cpython\Include\pyconfig.h
C:\Users\Noo\Documents\Els_kom_new-master\PCbuild..\bin\x86\Release\_freeze_pyeimport C:\Users\Noo\Documents\Els_kom_new-master\PCbuild..\Tools\pyeimport.py C:\Users\Noo\Documents\Els_kom_new-master\PCbuild..\PC\pyeimport.h pyeimport

:VCEnd" exited with code 9009. komextract_new C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets 123

Severity Code Description Project File Line Suppression State
Error C1083 Cannot open include file: 'io.h': No such file or directory _freeze_pyeimport c:\users\noo\documents\els_kom_new-master\externals\cpython\include\pyconfig.h 59

Severity Code Description Project File Line Suppression State
Error MSB3073 The command "echo F|xcopy /Y /c C:\Users\Noo\Documents\Els_kom_new-master\PCbuild..\etc\pyconfig.h C:\Users\Noo\Documents\Els_kom_new-master\PCbuild..\externals\cpython\Include\pyconfig.h
C:\Users\Noo\Documents\Els_kom_new-master\PCbuild..\bin\x86\Release\_freeze_pyeimport C:\Users\Noo\Documents\Els_kom_new-master\PCbuild..\Tools\pyeimport.py C:\Users\Noo\Documents\Els_kom_new-master\PCbuild..\PC\pyeimport.h pyeimport

:VCEnd" exited with code 9009. kompact_new C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets 123

Severity Code Description Project File Line Suppression State
Error C1083 Cannot open include file: 'ctype.h': No such file or directory Els_kom c:\program files (x86)\windows kits\8.1\include\um\winnt.h 31

Debug information

• Els_kom version: [your version here]
• OS: [Win 8.1]
• OS Arch: [Your OS Arch here]
• OS Build: [Your OS Build here]

Note: Newer versions from time to time ship with a newer version of python embedded.

Fix suggestion

This is a Issue for me to remember integrating the common modules in 1 place to make it use 1 copy instead of 3 of them for each project.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
No

Describe the solution you'd like
A clear and concise description of what you want to happen.
A possible move from Windows forms to a xaml based control & window system.
Pro: Might work with any system supporting xaml based windows.
Con: Adds managed resources?

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
None yet really.

Additional context
Add any other context or screenshots about the feature request here.
https://docs.microsoft.com/en-us/dotnet/framework/wpf/advanced/windows-forms-controls-and-equivalent-wpf-controls
https://www.win2wpf.com/
System.Windows.Forms.Timer -> System.Windows.Threading.DispatcherTimer
Hopefully this can be all that is needed. We do however need to smart port all of this though.

So for the entire team to deliberate: Should I Move branch icon to a subfolder in master or the root of master, and also have the legacy branch files under a "legacy" subfolder for historical reasons so that way there would only be a single branch to maintain or worry about other than feature ones?

cc: @Elskom/core-team

Issue Description

WinStudio 2017 Vr. Korean
you look in the lower left corner is '빌드에 성공했습니다'
'빌드에 성공했습니다' -> 'complete to Build'

complete to 'Build'
What's next?

I'm confused, to see 'To Build'
Could you explain it in detail with the picture?
please

Issue Description

Inconsistencies in the current readme, and formatting issues in it.

Debug information

• Els_kom version: 1.4.9.8
• OS: Windows 7 Ultimate
• OS Arch: x64
• OS Build: 7601

Note: Newer versions from time to time ship with a newer version of python embedded.

Fix suggestion

An possible rename of the readme.txt file or changing how it is constructed?

Should we go with an similar system like Python's Misc/news or no?

Happens only when the Tray icon is showing and not when both or the Taskbar one is showing.

Describe the bug
By following the guides on how to build both Els_kom_new as well as Elskom.Sdk I encounter an issue where trying to build Els_kom_new (either via Visual Studio 2019/2019 Preview) will result in errors most likely related to the version of dependencies used is below the required ones.

To Reproduce
Build Elskom.Sdk as explained on the above mentioned guide and add the directories to NuGet.
Proceed then to build Els_kom_new as explained on the above mentioned guide
EIther open up the solution via Visual Studio or run the command
Notice the warnings:

SettingsFile 2.0.0 depends on System.Text.Json (>= 6.0.0-preview.3.21162.11) but System.Text.Json 6.0.0-preview.3.21162.11 was not found. An approximate best match of System.Text.Json 6.0.0-preview.3.21163.4 was resolved.	Els_kom
Microsoft.Extensions.DependencyInjection (>= 6.0.0-preview.3.21162.11) but Microsoft.Extensions.DependencyInjection 6.0.0-preview.3.21162.11 was not found. An approximate best match of Microsoft.Extensions.DependencyInjection 6.0.0-preview.3.21163.4 was resolved.

Notice the errors:

`string[]' does not contain a definition for 'Source' and no accessible extension method 'Source' accepting a first argument of type 'string[]' could be found (are you missing a using directive or an assembly reference?)	Els_kom (net472), Els_kom (net5.0-windows)

Most likely due to this, this error will pop up which leads to the build to fail. It might be worth mentioning that I was unable to find the versions required, even when looking into future versions of such dependencies.

Expected behavior
The solution is sucessfully built.

Screenshots

The Python console Apps are Good but are not good with my DLL that should do the Crypto++ work when Alg 3 is Added in.

Things to Consider:
1: Args must be the same as the Python Ones to avoid breaking the bat files.
2: Algorithm 3 Support.
3: Smaller Files than the Python PyInstaller Compiled ones.
4. Faster
5. No waste of disc space every time it is used to unpack or pack things unlike pyintaller compiled ones that would waste a ton of space to use on every execution.

Describe the bug
I can't figure this out. I'm not a C# coder so I'm not good with this kind of stuff but no matter what I do I can't get the solution file working.

To Reproduce
Steps to reproduce the behavior:

1. Clone repository
2. Open .sln file in Visual Studio 2019

Expected behavior
The .sln file opens fine and is able to be built

Screenshots

Desktop:

• OS: Windows
• OS Arch: x64
• OS Label Version: 10
• OS Edition: Education
• OS Build: 19041.1348
• Version: 2004

Additional context
I've gone over the other issues and discussions and tried what's in them but it just doesn't work no matter what I do. I don't know if I'm missing a component or not, I'm so lost.

I am considering for the version 1.4.9.7 that I should move most of the stuff to other controls to considerably size down the code of the forms if I can possible do it. Even if I can only do it for a single form only for now.

Issue Description

Basically what the issue title states, replace them so we can compile easier and add maybe an extension interface to the pack and unpackers to maybe Algorithm 2 and 3 (so we can finnally close #21).

Debug information

• Els_kom version: 1.4.9.8
• OS: Windows 7 Ultimate SP1
• OS Arch: `1x64``
• OS Build: 7601

Note: Newer versions from time to time ship with a newer version of python embedded.

I tried so many times to compile this to no avail.
i gave up then use the legacy version instead..

but here s one thing. i dont know how you re supposed to use this program. i tried copying the .kom files i want to the bin folder. and press unpack. but nothing happen. so can you write a simple tutorial on how to use the program in the read.md many thanks.

Describe the bug
I cant find it actually because i'm not c# coder but I tried my best

To Reproduce
Steps to reproduce the behavior:

1. run git clone https://github.com/Elskom/Els_kom_new.git in "C:"
2. run dotnet build --configuration Release --ignore-failed-sources
3. build failed (see that screenshot)
4. founded seems like solution in https://github.com/Elskom/Els_kom_new/issues/190#issuecomment-1000549324
5. run dotnet tool restore
6. run dotnet elskom-check install
7. run dotnet build -c Release
8. still build failed with same problem

Expected behavior
build successfully with cmd or visual studio community 2022

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: windows
• OS Arch: x64
• OS Label Version: 11 (If i need windows10, i can use it)
• OS Edition: home (but windows10 is pro)
• OS Build: 22000.856 (but windows10 is 19044.1889)
• Version: 21H2 (windows10 also same 21H2)

Additional context
I finding someone have a same problem in issues and discussions but i can't find it
i checked PATH already and Elskom.Sdk seems like installed fine in C:\Program Files\dotnet\packs\Elskom.Sdk
I can't understand why cmd still not find Elskom.Sdk please help ;-;

Describe the bug
1.I put the. KOM file or the newly created dataxxx folder into "F:\source\repos\elskom_new\bin\Release\net6.0-windows10.0.22621.0", and it will report errors like the following picture.
2.The button on the right of the set game path will crash, but you can copy the path directly.

To Reproduce
Steps to reproduce the behavior:
1.Install dependencies
2.Step by step build the .exe

Expected behavior
Build successfully with visual studio 2022.

Screenshots

Desktop (please complete the following information):

• OS: windows
• OS Arch: x64
• OS Label Version: 10
• OS Edition: Professional
• OS Build: 10.0.22621
• Version: 21H2

Additional context
Give me some hints,Please.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The inability to convert KOM V2 crc.xml's to a KOM V3 or V4 one, or a KOM V3/V4 one to a V2 one.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Converters that can handle converting KOM V2 crc.xml's to a KOM V3 or V4 one, or a KOM V3/V4 one to a V2 one. But would have to first detect the version of crc.xml it is.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Nothing other than the converter methods.

Additional context
Add any other context or screenshots about the feature request here.

Issue Description

The lack of support for V2 kom files triggers me.

Debug information

• Els_kom version: v1.4.9.8
• OS: Windows 7
• OS Arch: x64
• OS Build: 7601

Note: Newer versions from time to time ship with a newer version of python embedded.

Fix suggestion

Adding support for v2 kom files somehow.

Describe the bug
A clear and concise description of what the bug is.

I think this is due to reading the settings while doing to packing, unpacking, testing mods, and the updating functionality.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.
Hardly any cpu usage other than the usage when packing or unpacking.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. windows, linux, mac] Windows
• OS Arch: [e.g. x86, x64] x64
• OS Label Version: [e.g. 7, 8, 8.1, 10, 17.04] 7
• OS Edition: [e.g. Starter, Home, Professional, Enterprise, Ultimate, None] Ultimate
• OS Build: [e.g. 7601] 7601
• Version [e.g. 1.4.9.8] 1.4.9.8

Additional context
Add any other context about the problem here.

This is a open issue until all compile Warnings are Removed and fixed.

Describe the bug
It fails to load the project.

To Reproduce
Steps to reproduce the behavior:
0. Install newest .Net

1. Click on pcbuild.sln and open it with VS 2022.
2. Get "C:\Users\me\Desktop\Neuer Ordner (2)\Els_kom_new\Els_kom\Els_kom.csproj : error : Die Projektdatei kann nicht geöffnet werden. C:\Program Files\dotnet\sdk\6.0.101\Sdks\Elskom.Sdk\Sdk wurde nicht gefunden. Stellen Sie sicher, dass eine aktuelle Version des .NET SDK installiert ist, und/oder erhöhen Sie die in "global.json" angegebene Version."

Expected behavior
The expected behaviour is for it to load, but it does not.

Desktop (please complete the following information):

• OS: Windows 10

This is a Issue for me to add Algorithm 3 Support. Hopefully I can do it.

Hello, dear author.
I am a Chinese server player.
I like elswrod very much.
I also like to make and replace sounds.
A few years ago, I was fortunate enough to use two voice unpacking tools you made.
But the last unpacking tool is no longer available.
Under the recommendation of a friend.
I found it here.
But my English is very poor.
With the help of Google, I can hardly understand.
I don't know how to decompress the voice package
This leaves me at a loss.
I think I did not find the relevant steps you wrote.
Are there any relevant instructions for use?
At present, with the guidance and help of friends,
Download and install visual studio 2019 and Python27
But only the previous voice can be packaged.
Although it is presumptuous
But i want to get your reply and help
Or the relevant description page.
Finally, looking forward to your reply, I wish you a happy life!

Issue Description

I followed all the steps but still cant build it right

Debug information

• Els_kom version: [1.4.9.8]
• OS: [win 10 Home]
• OS Arch: [Your OS Arch here]
• OS Build: [Your OS Build here]

Note: Newer versions from time to time ship with a newer version of python embedded.

Fix suggestion

These batch has became unmanageable and goes out of date pretty fast every time kog releases new kom files. As such we must support and look for any files with the .kom extension instead.