elvishjerricco / servant-router Goto Github PK

This took me so stupidly long to figure out!!

runRoute will return FailFatal on any relative URI's, per the behaviour of Network.URI.parseURI. I think the behaviour of parseURI has been changed in network-uri 2.6 or something.

Anyway, this is very problematic, because Reflex.Dom.Contrib.Router.routeSite returns relative URI's, and thus doesn't work with this library.

I think the solution is simply to change runRoute to use parseURIReference instead. There might also need to be a preprocessor check for old versions of nework-uri..?

Right now you're exporting everything.

@ElvishJerricco you have moved package into subfolder but README.md stays in repo root and yet it's listed in servant-router/servant-router.cabal as extra-source-files.
I guess it's better be fixed.
BTW what was the motivation of that move?

I'm wondering why #4 was closed when example from README still doesn't work properly

I was trying to create muli-page app with this package but I just don't get how does it work with normal reflex logic.
I my SPA I just use mainWidget which wraps MonadWidget into IO returning () as a result. And routeSite wants events as handler outputs. Thus the example from README with just el "div" $ text "Sample text" added into and handler fails to compile with

    /home/qrilka/ws/example-app/src/Main.hs:41:7: error:
        • Could not deduce: m ~ IO
          from the context: MonadWidget t m
            bound by a type expected by the context:
                       MonadWidget t m => String -> m (Event t String)
            at src/Main.hs:(23,8)-(45,23)
          ‘m’ is a rigid type variable bound by
            a type expected by the context:
              forall t (m :: * -> *).
              MonadWidget t m =>
              String -> m (Event t String)
            at src/Main.hs:23:8
          Expected type: m ()
            Actual type: IO ()
        • In a stmt of a 'do' block:
            mainWidget $ do { el "div" $ text "Sample text" }
          In the expression:
            do { mainWidget $ do { el "div" $ text "Sample text" };
                 return never }
          In a case alternative:
              Left _
                -> do { mainWidget $ do { el "div" $ text "Sample text" };
                        return never }
        • Relevant bindings include
            handler :: forall t1 a t2 a1.
                       (t1 -> ExceptT RoutingError m (Event t a))
                       :<|> (Maybe t2 -> ExceptT RoutingError m (Event t a1))
              (bound at src/Main.hs:24:7)

Hi, thanks for this library, it's conceptually very clean. I have only an issue which it's stopping me from using it fully: in your tutorial there is the snippet:

main = routeSite $ \uri -> do
  let handler = books :<|> search
      books i = do
        ...omitted...
        return never
      search Nothing = do
        ...omitted...
        return never
      search (Just keywords) = do
        ...omitted...
        return never

Now, in this example you always return never, but I'd like to actually use the text signal I'm returning to navigate away from the page (it enables me to use more sophisticated navigation).

So, let's say I trigger a text, signalling my intent to move to the page at that url. Unfortunately, for how routeSite is implemented, the address changes in the title bar, but the actual page doesn't change! How could I change the structure in the tutorial so that the firing of the returned Event t Text also change the page I'm in?

Here's the code of routeSite: as you can see, it only sets the url:

routeSite
    :: (forall t m. MonadWidget t m => Text -> m (Event t Text))
    -> IO ()
routeSite siteFunc = runWebGUI $ \webView -> do
    w <- waitUntilJust currentWindow
    path <- getWindowLocation w
    doc <- waitUntilJust $ liftM (fmap castToHTMLDocument) $
             webViewGetDomDocument webView
    body <- waitUntilJust $ getBody doc
    attachWidget body (WebViewSingleton webView) $ do
      changes <- siteFunc (T.pack path)
      setUrl $ T.unpack <$> changes
      return ()

Do you have any suggestion or a more complex example that makes use of the returned event?

I need to render links in my app (as routeSite is not "recursive" see reflex-frp/reflex-dom-contrib#19) so currently I use ViewTransform but that leads to views being duplicated in routes so I could pass them to safeLink.
And it makes me wonder if its possible somehow to make safeLink work on View directly

Is there any reason the dependency is so narrow? It prevents building with servant-server > 0.7.1.

I see on hackage versions that 0.7.1, 0.8.0 and 0.8.1 for this package. As there is no changelog for it I wanted to check github version tags but didn't find any. It would be great if you could add them or maybe use some other convenient way to make changes.easily trackable

I have a simple page and returning a new URI from my handler has no effect. I'm using latest Reflex-DOM and reflex-dom-contrib on GitHub as of today.