emacs-eaf / eaf-video-player Goto Github PK

Describe the bug
press h or l key, or use mouse to change time video time, cannot hear sound anymore

Additional context
ubuntu 22.04, newest eaf

• If EAF was working correctly until a recent git pull, please refer to Mandatory Procedures to Keep Your EAF Up-to-Date first.
• Please check the *eaf* buffer, if there is any error shown in the *eaf* buffer, paste it here.

Describe the bug
when using j or k key, get error message:

in eaf buffer, find detail as following:

Traceback (most recent call last):
  File ".emacs.d/elpa/28.1/develop/eaf-20221110.2200/eaf.py", line 368, in eval_function
    getattr(buffer, function_name)()
  File ".emacs.d/elpa/28.1/develop/eaf-20221110.2200/core/utils.py", line 190, in wrapped_f
    return f(*args, **kwargs)
  File ".emacs.d/elpa/28.1/develop/eaf-20221110.2200/app/video-player/buffer.py", line 193, in decrease_volume
    self.media_player.setVolume(self.media_player.volume() - 10)
AttributeError: 'QMediaPlayer' object has no attribute 'setVolume'

Additional context
Ubuntu 22.04 , emacs 28.1

Describe the bug
When viewing a video, said video may be much smaller than desired. This can be somewhat difficult to force to occur, but it appears to happen if the initial Emacs window is small. In that case, the video player will load the video to fill up the initial, small Emacs window's size, but if Emacs is later maximized, the video does not increase in size to fill the entire screen as one might wish. It does not happen if the initial window was large and is then resized to be smaller, then made larger again.

To Reproduce

This is a little hard to make happen, and it doesn't appear to be completely consistent. However, the following seems to cause the error to appear most of the time (the precise steps are done with AwesomeWM and are described as such):

1: Open a new Emacs client in a small window
2: Open a video to see it is small
3: Increase the size of the Emacs window, the video does not increase much to match
4: Close that Emacs, switch to a new AwesomeWM virtual desktop with no windows open, and change tiling settings to something which will make a new window fill up the screen (super-space will do this if there is nothing else open on the virtual desktop. If using a different window manager, some other method may be needed to ensure the next Emacs client is maximized right as it opens)
5: Open a new Emacs instance, ensuring it takes up the entirety of the desktop monitor view
6: Open a video to see it is in full screen as expected

Expected behavior
The video would dynamically resize when the size of the Emacs window is changed, regardless of the original size of the Emacs window when it is first opened. Alternatively, buttons to zoom in and out would resolve this by sidestepping the issue.

Versions (please complete the following info):

• Distro and DE/WM: Ubuntu 20.04.3 LTS, AwesomeWM
• Versions of Dependencies: Unknown
• M-x emacs-version: GNU Emacs 27.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2021-11-04

Screenshots

This screenshot is a bit hideous, but as you can see the video being played (just a couple seconds of capturing my own desktop) is a lot smaller than the image, and surrounded by blackness. This blackness is in fact Emacs, which I enlarged but the video did not also become enlarged.

Additional context
Add any other context about the problem here.