Error with search query starting with "or" about helm-notmuch HOT 8 CLOSED

Unfortunately, I stopped using Notmuch long time ago and I am afraid I won't investigate the issue anytime soon. But meanwhile helm-notmuch is a very simple package - it uses the notmuch command line tool to collect search results and display them using helm, so if the issue is caused by helm-notmuch, it should not be very hard to figure out.

from helm-notmuch.

I'll give it a try then.

from helm-notmuch.

@xuchunyang: Out of curiosity, what are you using now and why did you stop using Notmuch?

from helm-notmuch.

@Ambrevar I'm not a heavy user of email, e.g., I sent only one email since this month.

from helm-notmuch.

I think I've got and answer to this:

(defun helm-notmuch-candidate-formatter (cand)
  "Format the single entry CAND."
+  (if (not (string-match-p "\\[" cand ))
+      ""
  ...

Basically when querying something that Xapian does not understand, notmuch returns an error. Example

> notmuch search "date:foo"
notmuch search: A Xapian exception occurred
A Xapian exception occurred parsing query: Didn't understand date specification 'foo'
Query string was: date:foo

In helm-notmuch-collect-candidates, instead of start-process we could use something like this:

(make-process :name "helm-notmuch"
              :buffer helm-buffer
              :command cmds
              :connection-type 'pipe
              :stderr helm-notmuch-log-buffer)

from helm-notmuch.

Note that the first suggestion is the real fix, the second is only an improvement in terms of error reporting.

@xuchunyang: Would you take a PR?

from helm-notmuch.

@Ambrevar Yes, I'll accept such PR as long as it improves the situation.

from helm-notmuch.

Fixed with dae426c.

from helm-notmuch.