Comments (13)
thierryvolpiatto
commented on June 6, 2024
Pierre Neidhardt <[email protected]> writes:
This is an issue that is general to Helm, but I'm not sure how to tackle it.
@thierryvolpiatto?
I don't see such error in Helm, TAB is bound to action menu and then the
helm-pattern is reset to nothing until you hit TAB again, when pressing
RET the action under cursor is executed with the candidate selected in
the helm-buffer, what's wrong with this?
For helm-notmutch I don't know, I don't use it.
…--
Thierry
from helm-notmuch.
Ambrevar
commented on June 6, 2024
The problem is with the following function:
```
(defun helm-notmuch-search (candidate)
"Display notmuch query in notmuch-search buffer, highlighting CANDIDATE."
(notmuch-search (helm-notmuch-maybe-match-incomplete helm-pattern)
nil
(replace-regexp-in-string "^thread:" "" candidate)))
```
It needs the `helm-pattern` that was used in the prompt outside the
action menu.
So when we are in the action menu, pressing `RET` on this
action will call it with an empty (or different) `helm-pattern`. What
`helm-notmuch-search` really expect is the `helm-pattern` that was used
before entering the action menu.
Does that make sense?
from helm-notmuch.
thierryvolpiatto
commented on June 6, 2024
Pierre Neidhardt <[email protected]> writes:
The problem is with the following function:
```
(defun helm-notmuch-search (candidate)
"Display notmuch query in notmuch-search buffer, highlighting CANDIDATE."
(notmuch-search (helm-notmuch-maybe-match-incomplete helm-pattern)
nil
(replace-regexp-in-string "^thread:" "" candidate)))
```
It needs the `helm-pattern` that was used in the prompt outside the
action menu.
So when we are in the action menu, pressing `RET` on this
action will call it with an empty (or different) `helm-pattern`. What
`helm-notmuch-search` really expect is the `helm-pattern` that was used
before entering the action menu.
Does that make sense?
IIUC you want the last value of helm-pattern before switching to helm
action menu?
You can retrieve it in `helm-input-local` if needed.
IOW instead of:
(notmuch-search (helm-notmuch-maybe-match-incomplete helm-pattern)
use
(notmuch-search (helm-notmuch-maybe-match-incomplete helm-input-local)
…--
Thierry
from helm-notmuch.
Ambrevar
commented on June 6, 2024
I had to use
(with-helm-buffer helm-input-local)
and it works now! Thank you Thierry!
@xuchunyang: I'll send another patch for this.
Since you are no longer using it, are you still willing to maintain it?
If not, I'd be happy to adopt it and move it to the Emacs-Helm
organization, if @thierryvolpiatto agrees :)
from helm-notmuch.
xuchunyang
commented on June 6, 2024
@Ambrevar I don't have much motivation to maintain it. That will be great if you or someone else can maintain it, if @thierryvolpiatto agrees, I will move the repository to the Emacs-Helm organization.
from helm-notmuch.
thierryvolpiatto
commented on June 6, 2024
Xu Chunyang <[email protected]> writes:
@Ambrevar I don't have much motivation to maintain it. That will be
great if you or someone else can maintain it, if @thierryvolpiatto
agrees, I will move the repository to the Emacs-Helm organization.
No problem, you can move it to emacs-helm.
…--
Thierry
from helm-notmuch.
xuchunyang
commented on June 6, 2024
Great, I've moved it to emacs-helm.
@Ambrevar I'm not sure if you have necessary permissions to maintain the repo, such as push code, close issues and merge pull requests. By the way, it seems github redirects the old URL to the new one, so we don't have to update the Melpa recipe.
from helm-notmuch.
Ambrevar
commented on June 6, 2024
No, I don't have permissions. Could you grant them to me? Thanks!
from helm-notmuch.
xuchunyang
commented on June 6, 2024
It seems that's impossible for me, I didn't see the Settings panel at https://github.com/emacs-helm/helm-notmuch, I think @thierryvolpiatto can grant these permissions to you since he is the owner of the emacs-helm organization.
from helm-notmuch.
thierryvolpiatto
commented on June 6, 2024
Pierre Neidhardt <[email protected]> writes:
No, I don't have permissions. Could you grant them to me? Thanks!
Done!
…--
Thierry
from helm-notmuch.
thierryvolpiatto
commented on June 6, 2024
Xu Chunyang <[email protected]> writes:
Great, I've moved it to emacs-helm.
Thanks.
…--
Thierry
from helm-notmuch.
Ambrevar
commented on June 6, 2024
Fixed in d6d5529.
from helm-notmuch.
Ambrevar
commented on June 6, 2024
Thank you @xuchunyang and @thierryvolpiatto !
from helm-notmuch.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm-notmuch.