emartech / boar-server Goto Github PK

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-4
Explanation: Is it compliant with REUSE rules? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-3
Explanation: Is it registered in REUSE? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

PaS providers like Heroku expecting the server, worker, bin (scheduler for example) and clock (clock process) code in the same deployed directory.
It's possible to do now in the boar-stack if you put everything under the server dir and keep client as it is. Because in this case it will be copied during the build under the dist, what will be deployed to Heroku.
It would be more cleaner to having an src directory which can contain server, worker, bin, clock and the builded client after build.

In nutshell I recommend to include a new dir level the src and copy it during the build instead of the dist.

In this case the Procfile can be:

web: node server           // server/index.js
worker: node worker      // worker/index.js
clock: node clock           // clock/index.js

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-1
Explanation: Does README mention REUSE? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Packages that were updated in boar-server are not compatible with koa@1, especially koa-router which breaks compatibility at v7.

We had to migrate our app to koa v2 which required some changes to adapt generator functions into asynchronous function (with the help of co).

I see several ways to workaround :

• Either we revert back to router v7 (which is really old)
• Or we encapsulate some of the required transformations inside boar-router (in particular the controllers loading)

See the following commit for details.

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-2
Explanation: Does it have LICENSES directory with licenses? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html