Giter VIP home page Giter VIP logo

Comments (6)

bmish avatar bmish commented on May 28, 2024 1

We can't control what order people set their configs in or whether they use a parser globally. So it sounds like a breaking change.

@patricklx let's do a revert then. Is there another approach you'd like to try that isn't breaking? Or an acceptable breaking change that we should save for a major release?

from eslint-plugin-ember.

patricklx avatar patricklx commented on May 28, 2024 1

yes, that's what ember plugin also does in the recommended config. But eslint does not override the parser if its specified globally in the config :(

from eslint-plugin-ember.

Techn1x avatar Techn1x commented on May 28, 2024

A suggestion made here was to not specify a parser #1920 (comment)

Unfortunately, that does not seem to resolve the issue (I've commented out my typescript-eslint parser in my eslintrc.js file)
Screenshot 2023-08-22 at 9 27 43 pm
(note: I also tried plugin:@typescript-eslint/base instead of recommended for the plugin, no luck with that either)

from eslint-plugin-ember.

bmish avatar bmish commented on May 28, 2024

As mentioned in #1920 (comment), if #1920 is a breaking change, we will need to revert it.

from eslint-plugin-ember.

Techn1x avatar Techn1x commented on May 28, 2024

After some messing around, what does fix it, is if I place the ember config after the typescript-eslint config, as well as commenting out the parser. recommended or base doesn't seem to matter for the typescript-eslint config here.

Screenshot 2023-08-22 at 9 45 14 pm

The parsing errors I mentioned go away (I just get a whole bunch of different ones, but I don't think they're related)

from eslint-plugin-ember.

Techn1x avatar Techn1x commented on May 28, 2024

Just FWIW: the @typescript-eslint/base config overrides the parser here

https://github.com/typescript-eslint/typescript-eslint/blob/5ee1dfe872f67cb504c89e95b1450a65802e11a8/packages/eslint-plugin/src/configs/base.ts#L9

from eslint-plugin-ember.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.