Comments (6)
We can't control what order people set their configs in or whether they use a parser globally. So it sounds like a breaking change.
@patricklx let's do a revert then. Is there another approach you'd like to try that isn't breaking? Or an acceptable breaking change that we should save for a major release?
from eslint-plugin-ember.
yes, that's what ember plugin also does in the recommended config. But eslint does not override the parser if its specified globally in the config :(
from eslint-plugin-ember.
A suggestion made here was to not specify a parser #1920 (comment)
Unfortunately, that does not seem to resolve the issue (I've commented out my typescript-eslint parser in my eslintrc.js file)
(note: I also tried plugin:@typescript-eslint/base
instead of recommended for the plugin, no luck with that either)
from eslint-plugin-ember.
As mentioned in #1920 (comment), if #1920 is a breaking change, we will need to revert it.
from eslint-plugin-ember.
After some messing around, what does fix it, is if I place the ember config after the typescript-eslint config, as well as commenting out the parser. recommended or base doesn't seem to matter for the typescript-eslint config here.
The parsing errors I mentioned go away (I just get a whole bunch of different ones, but I don't think they're related)
from eslint-plugin-ember.
Just FWIW: the @typescript-eslint/base
config overrides the parser
here
from eslint-plugin-ember.
Related Issues (20)
- [email protected] detects single-line components as zero-line components HOT 3
- Drop Recommended Rules for Deprecated Ember 3.x Features HOT 2
- Replace ember-template-imports with content-tag HOT 2
- New rule proposal: require-components-imports-pascal-case HOT 2
- config files in readme should not encourage top level config. overrides only.
- ESLint couldn't find the config "plugin:ember/gts-recommended" to extend from HOT 4
- false positives for `no-unused-vars` in `gjs` files, when using `<Component as |something|>` HOT 3
- gjs/gts Incorrect token mapping after handlebars HOT 1
- Support "Type aware" linting for gts files HOT 13
- "service" import not treated the same as "inject as service" HOT 1
- no-unused-expressions HOT 4
- Plan v13 Release HOT 4
- new "flat" configs contain invalid parser key HOT 19
- `@typescript-eslint` breaks after update to `eslint-plugin-ember` v12 HOT 19
- ember/template-no-let-reference HOT 4
- ember/no-runloop HOT 4
- New rule: prevent assignment of existing properties on a service (important for tests)
- @typescript-eslint/eslint-recommended not applicable to `*.gts` files HOT 1
- Should we provide a config that disables some rules from `@typescript-eslint/eslint-plugin`? HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-ember.