ember-cli / watch-detector Goto Github PK

This seems to be primarily created for ember-cli to use, and was an extraction of the detection logic from there I'd like to suggest moving the repo into the ember-cli org and adding a few more ember-cli contributors as npm owners.

@chrmod - What do you think?

https://github.com/paulmillr/chokidar is pretty much the defacto replacement for wanting to use watch in node. Could be cool to be able to toggle this. It seems like it would be easily combined with #6.

so the client can be sure what type was returned, for example:

  const detector = new WatchDetector(..);
  const watchPreference = detector.findBestWatcherOption({ watcher: options.watcher });
  const watcher = watchPreference.watcher;

  const saneOptions = {
    poll: watcher === WatchDetector.POLLING ,
    watchman: watcher === WatchDetector.WATCHMAN,
    node: watcher === WatchDetector.NODE,
  };

Installing watchman via

brew install watchman

provides the new version of 20210328.072220.0. Which results in

Invalid watchman found, version: [20210328.072220.0] did not satisfy [>= 3.0.0].
Visit https://ember-cli.com/user-guide/#watchman for more info

Getting error:

Invalid watchman found, version: [2021.08.02.00] did not satisfy [>= 3.0.0].
Visit https://ember-cli.com/user-guide/#watchman for more info.

How I install watchman?

brew install watchman

watchman -v   -> 2021.12.20.00

• move package under ember-cli or broccoli organization
• enable travisci and appveyor
• add README

prior art: #12

Use case: our developers occasionally make changes to our internal Ember Addons that are consumed by our host app, and they do so while running the host app's dev server instead of the addon's. This worked fine in Watchman v4.9.0, but the recent changes to the versioning format broke it and now changes to the addon do not trigger a rebuild of the host app.

Most of the semver-related issues were fixed in #13, but this one remained. Since that PR removed most of the version checks (and the corresponding test), I'm going to open a PR that finishes the job and removes the one remaining version check.

code: https://github.com/ember-cli/ember-cli/blob/master/lib/models/watch-detector.js
tests: https://github.com/ember-cli/ember-cli/blob/master/tests/unit/models/watch-detector-test.js