Giter VIP home page Giter VIP logo

Comments (6)

dmathieu avatar dmathieu commented on May 25, 2024

The ember naming convention would make it appendAddon.
I don't think the proposed solution really fits with emberjs. Anything can be set, from text to buttons.
So it'd require to be able to set a view as the add-on.

from ember-bootstrap.

siovene avatar siovene commented on May 25, 2024

The reason why I was asking that it be set with the TextField, is that I cannot do something like this:

<div class="input-append">
  {{view Bootstrap.Forms.TextField valueBinding="price"}}
  <span class="add-on">$</span>
</div>

because ember-bootstrap will wrap the <input> tag with bootstrap markup, like control-group. So the add-on span will not work.

To make this work, the implementation must be somewhere in ember-bootstrap, mustn't it?

from ember-bootstrap.

bradleypriest avatar bradleypriest commented on May 25, 2024

@siovene I don't know if this would be used commonly enough to warrant adding the option.

I suggest creating a custom view in your app. Off the top of my head

javascript
Bootstrap.Forms.AppendedTextField = Bootstrap.Forms.Field.extend({
template: Ember.Handlebars.compile([
'{{view view.labelView viewName="labelView"}}',
'

',
'
',
' {{view view.inputField viewName="inputField"}}',
' {{view.appendAddon}}',
'
',
' {{view view.errorsView}}',
'
'].join("\n"))
});


Maybe worth documenting somewhere though

from ember-bootstrap.

siovene avatar siovene commented on May 25, 2024

Thanks for the suggestion, I'll do that. Perhaps it's not common, but it would be nice if ember-bootstrap provided it.

from ember-bootstrap.

bradleypriest avatar bradleypriest commented on May 25, 2024

My main problem with ember-bootstrap providing it is that it would require every non-prepended input i.e. the vast majority of them to have to process whether or not they have the property. Maybe there's a better way to do it though.

from ember-bootstrap.

dmathieu avatar dmathieu commented on May 25, 2024

I'm closing this as it won't be implemented as proposed.
If you want to propose an alternative, please create a discussion in our newly created google group.

from ember-bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.