Comments (5)
Yeah, the modal pane has been broken for quite a while with ember 1.0.pre whilst setting a rootElement
on the application because it is appending the modal pane outside of the applicationView.
I meant to have posted an issue a while ago.
This is how I've currently hacked it to work in my app. I'll get a test and PR (a different fix though) for it up in the next couple of days, thanks for the minimal app.
Bootstrap.ModalPane.reopen({
_triggerCallbackAndDestroy: function(options, event){
this._super(options, event);
App.router.applicationController.set('modal', null);
}
});
Bootstrap.ModalPane.reopenClass({
popup: function(options) {
var modalPane;
if (!options) options = {};
modalPane = this.create(options);
App.router.applicationController.set('modal', modalPane);
return modalPane;
}
});
from ember-bootstrap.
Here's a better short-term fix:
Bootstrap.ModalPane.reopenClass({
popup: function(options) {
var modalPane;
if (!options) options = {};
modalPane = this.create(options);
modalPane.appendTo(App.rootElement);
return modalPane;
}
});
from ember-bootstrap.
I haven't tested the following, but won't appending the backdrop to the root element rather than body
break the z-indexing in IE?
from ember-bootstrap.
@siovene Does PR #37 fix your issue?
from ember-bootstrap.
While there's no news from @siovene, I'm merging #37 anyway.
The modal should anyway be scoped inside the .ember-application.
About the z-index problem in IE, it would be easily fixable in CSS by adding a higher lower z-index to .ember-application. So it doesn't seem to be a real problem.
from ember-bootstrap.
Related Issues (20)
- Table Sorting not working for fixed header scrolling table
- Ember-bootstrap added to twitstrap resources
- ISO8601Date error in Bootstrap.DatePicker HOT 1
- [enhancement] Add missing bower.json.
- Move Readme contents
- addon does not import bootstrap.js file.
- Unable to install any 1.0.0 version with npm HOT 1
- Refer to active project with the same name
- navlist bind to model HOT 1
- Alert Message not working HOT 4
- Button Group is not supported HOT 3
- Compiled files HOT 4
- Can't set templateName of custom bodyViewClass of ModalPane HOT 5
- how to use typeAhead? HOT 2
- use datepicker Uncaught TypeError? HOT 1
- Bootstrap V3 support HOT 1
- ISO8601Date is not defined HOT 2
- no such file to load -- bundler/setup HOT 1
- Add dist folder to repo? HOT 4
- select doesn't seem to style properly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-bootstrap.