Giter VIP home page Giter VIP logo

Comments (12)

dmathieu avatar dmathieu commented on May 24, 2024

I don't think btn-group would be a good addition. It is only an html tag, which has no use for any binding attribute.
And adding all the buttons programmatically would make it harder to maintain the template.
Just add a div btn-group with all your buttons around it.

from ember-bootstrap.

extesy avatar extesy commented on May 24, 2024

@dmathieu But it does have a useful binding: selected button! I would rather use one control with a single-variable binding than do jquery magic to figure out which of the buttons from the group is selected. It's actually quite similar to the dropdown list with options in this sense.

from ember-bootstrap.

dmathieu avatar dmathieu commented on May 24, 2024

I don't see any change, visible nor in the dom in the bootstrap documentation for the selected button in btn-group.

Anyway, selected button or not, the problem remains the same. This would be one very big handlebars helper with a lot of parameters in it, which would be very hardly usable.

from ember-bootstrap.

extesy avatar extesy commented on May 24, 2024

Selected button has 'active' class added to it. Why should the helper be big? How is list of buttons in div tag different from list of options in select tag?

from ember-bootstrap.

dmathieu avatar dmathieu commented on May 24, 2024

Buttons are components by themselves.
They need to have bindable attributes, and possibly change the current route when clicking on them.

An option in a select tag is only an array entry, which doesn't behaves as a component by itself. It exists only because it is wrapped around a select tag, which controls it.

from ember-bootstrap.

extesy avatar extesy commented on May 24, 2024

Yes, that's true, but I think it's ok to not support the full button's functionality for each individual button in a group. Some helper is better than no helper and the ability to bind to the currently selected button(s) is very useful in itself.

from ember-bootstrap.

diosney avatar diosney commented on May 24, 2024

@dmathieu : Hi, navigation bars are in this category too? I mean: are too complex of implement or otherwise they can be implemented in another way?

Can be used a mix of ember-bootstrap and twitter-bootstrap.js itself in the same project?

from ember-bootstrap.

dmathieu avatar dmathieu commented on May 24, 2024

@diosney: I think navigation bars could be implemented. And yes ember bootstrap and the native twitter bootstrap libraries can be used together.
Note : for the purpose of readability, it would be better to open a new ticket for new requests/issues.

from ember-bootstrap.

diosney avatar diosney commented on May 24, 2024

Sure, I will file a new issue with the navigation request.

Thanks.

from ember-bootstrap.

dmathieu avatar dmathieu commented on May 24, 2024

Hmm, I read progress bar, foolish me.
In fact, navbars have somewhat the same problem as button groups.

Look at modalPane for example.
It exists, but the buttons are currently having only the default bootstrap behavior. We can't use the router on them.
The problem with those groups is the same.

from ember-bootstrap.

diosney avatar diosney commented on May 24, 2024

Oh! I see. Thanks anyway, I will close the issue then referencing this one.

from ember-bootstrap.

dmathieu avatar dmathieu commented on May 24, 2024

Closing this one too. If you have an implementation to propose, please open a pull request.

from ember-bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.