Giter VIP home page Giter VIP logo

Comments (8)

rlivsey avatar rlivsey commented on May 14, 2024

There's probably some overlap with #72 here, so a child component could update a slot from its parent and not just the main yield.

from rfcs.

RobbieTheWagner avatar RobbieTheWagner commented on May 14, 2024

@rlivsey yes, there does appear to be some similar concepts there. I'm essentially looking for the same thing, but with the ability for it to automatically inherit parent template HTML and such.

from rfcs.

tsing80 avatar tsing80 commented on May 14, 2024

I would like to simulate template inheritance using partial helper below. But since partial helper do not replace {{yield} with the child template. It didn't work:

app/components/base/component.js:

import Ember from ‘ember’;
export default Ember.Component.extend();

app/components/base/template.hbs:

<div>parent template{{yield}}</div>

app/components/child/component.js:

import Base from ../base/component’;
export default Base.extend();

app/components/child/template.hbs:

{{#partialcomponents/base}}
It didn't work
{{/partial}}

it would be nice if partial helper support {{yield}} in block form.

from rfcs.

locks avatar locks commented on May 14, 2024

@tsing80 Why use a partial instead of a component?

from rfcs.

tsing80 avatar tsing80 commented on May 14, 2024

@locks To render the template in the context of the child component.The child component extend the base component and will override some behaviour in the base component

from rfcs.

RobbieTheWagner avatar RobbieTheWagner commented on May 14, 2024

@locks what are your thoughts on this now? Should we be avoiding inheritance and opting for composability instead? Trying to assess if we should close this out or not.

from rfcs.

locks avatar locks commented on May 14, 2024

Thanks for pinging me @rwwagner90.

I believe that template inheritance is a footgun waiting to happen, and I'm not sure what the API for it would look like, since we wouldn't be able to change the current extending behaviour without breaking compatibility. I do think that composability is a better way forward, as you mention, and with the advent of tagless components there won't be the trade-off of extraneous div tags.
Adding to that the lack of movement, I'm for closing the issue. Thank you for filing it and bringing some discussion to the topic.

from rfcs.

RobbieTheWagner avatar RobbieTheWagner commented on May 14, 2024

@locks agreed. Closing. Thanks!

from rfcs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.