embulk-util-rubytime's Introduction

Almost Ruby-compatible date-time processor for Embulk and Embulk plugins

For Embulk plugin developers

Javadoc

For Maintainers

Release

Modify version in build.gradle at a detached commit, and then tag the commit with an annotation.

git checkout --detach master

(Edit: Remove "-SNAPSHOT" in "version" in build.gradle.)

git add build.gradle

git commit -m "Release vX.Y.Z"

git tag -a vX.Y.Z

(Edit: Write a tag annotation in the changelog format.)

See Keep a Changelog for the changelog format. We adopt a part of it for Git's tag annotation like below.

## [X.Y.Z] - YYYY-MM-DD

### Added
- Added a feature.

### Changed
- Changed something.

### Fixed
- Fixed a bug.

Push the annotated tag, then. It triggers a release operation on GitHub Actions after approval.

git push -u origin vX.Y.Z

embulk-util-rubytime's People

Contributors

Watchers

embulk-util-rubytime's Issues

Some zonetab IDs are imcompatible from Ruby 3.1

The zonetab-based timezone parsing is "deprecated" in embulk-util-rubytime, then we do not catch up with the update of Ruby. This issue is just to leave it as a note.

DateTime._strptime("...", "%z") behaves differently from Ruby 3.2

ruby/date#94

Confirm to have tests equivalent with embulk-core

Java src/test/java

org/embulk/config/TestConfigSource.java
- Including some tests w/ TimestampParser, but just using.
org/embulk/spi/time/TestRubyTimeFormat.java
- Same tests in org/embulk/util/rubytime/TestFormat.java
org/embulk/spi/time/TestTimeZoneIds.java
- Most regional timezones (ex. Asia/Taipei) are not supported in embulk-util-rubytime.
- Some are tested in org/embulk/util/rubytime/TestTimeZones.java.
- To be tested with LegacyEmbulkZones.java on the Embulk side.
org/embulk/spi/time/TestTimestamp.java
- Timestamp is Embulk's original class.
- Not tested in embulk-util-rubytime.
org/embulk/spi/time/TestTimestampFormatter.java
- Formatter is not implemented yet.
- Not tested in embulk-util-rubytime.
org/embulk/spi/time/TestTimestampFormatterParser.java
- It consists of tests as org.embulk.spi.Timestamp.
- Not tested in embulk-util-rubytime.
org/embulk/spi/time/TestTimestampParser.java
- These tests are to be imported.
org/embulk/spi/time/TestTimestampSerDe.java
- These tests are just for SerDe.
- Not tested in embulk-util-rubytime.

Ruby src/test/ruby

monkey_strptime/mri/date/test_date_strptime.rb
- Tested with org/embulk/util/rubytime/TestRubyDateTimeFormatterParseWithJRuby.java and src/test/resources/ruby/test/date/test_date_strptime.rb
vanilla/test_schema.rb
- Not to be tested in embulk-util-rubytime.
vanilla/guess/test_schema_guess.rb
- Not to be tested in embulk-util-rubytime.
vanilla/guess/test_time_format_guess.rb
- Not to be tested in embulk-util-rubytime.
vanilla/time/test_timestamp_parser.rb
- Some are identical with test_date_strptime.rb, but need to be investigated.