Giter VIP home page Giter VIP logo

person-manager's Introduction

Person Manager

This is a pair programming test that uses Spring Cloud Open Feign to call an external validator.

I failed this test because I didn't know that Spring AOP wouldn't work if @Retryable method and calling method were in the same class.

The problem is explained at Understanding AOP Proxies.

The solution is simply extracting the AOP-annotated methods into a separate class.

@Component
@RequiredArgsConstructor
@Slf4j
public class PersonValidator {

    private final ValidatorClient validatorClient;

    @Retryable(value = RuntimeException.class, backoff = @Backoff(5000))
    public String validatePhoneNumberDigits(String phoneNumber) {
        log.info("Calling #validatePhoneNumberDigits...");
        String response = validatorClient.validatePhoneNumberDigits(phoneNumber);
        log.info("#validatePhoneNumberDigits; " + response);
        return response;
    }
}

person-manager's People

Contributors

emeraldhieu avatar

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.