emeraldpay / emerald-wallet Goto Github PK

• Screen for interacting with contracts through eth_call
• Filter for installed contracts by feature

After transaction all buttons are inactive,
and transaction details missed on a result screen

While user trying to sent transaction, process stuck on traceCall with highlighted Account field. It's not obvious what goes wrong:

Show snakbar with tx id

eth_traceCall send invalid transaction, missed values into fields:
to field gets password , and gas gets receiver address

` {
"jsonrpc":"2.0",

"method":"eth_traceCall",

"params":[{
	"from":"0x6cb78dc25821748596aef43e0e618b83e274dc0e314c32ae47a30b811dc590f8",

	"to":"1234567890",

	"gas":"0xf0eb6c4578d1890c76d335406bc3e1edebe19bc2",

	"gasPrice":"0x5208",

	"value":"0x02540be400",

	"data":"0x00"}],

"id":10

}`

Current icons:

Why home is a face? Why a contract is a text? Why network is a motorcycle?

My, IMHO, personal suggestions:

For home:

For address book (just alternatives):

For contract:

For network selection:

For token (coin): nothing found ;(

We can try three another approarches:

1. Linking statically as Node.js Addon
2. Load dynamically via ffi
3. Write native module via Rust abstraction layer

Hello ETC pros,

I have a wallet with a couple hundred ETC's in it and it's been stuck in there since less than a month after ETC was released. However, didn't have time and couldn't find anywhere to find help, so here I am. That said, I will give you as much information as I can.

I first put the coin in there on a previous version, which I don't remember the initial version but I had the very first ETC wallet and that's where I sent my coin to. Ended up uninstalling and re-installing nearly every version up until 0.8.3 a few months after and ended up giving on it because I couldn't find any help. Today, I installed the latest mist version, still nothing. I'm really stupid when it comes to wallets and Mist didn't help at all with the confusion but I can follow instructions, I know how to run a web server, I'm not computer illiterate. I would like to get my coin out of this wallet and into something more stable, so I came here for assistance since the currency is ETC, this is where I should start troubleshooting. The ETC experts are here, right? I sure hope so.

Notes:
-Wallet been defective since Mist - 0.8.3
-Wallet is up to date (Mist - 0.8.9)
-Wallet is 7 months behind - Stuck on Block 2,111,708
-Which is when the wallet started having issues.
-Wallet ran for over a day and still not updating itself.
-Node counter fluctuates between 0 and 5 nodes.
-Ethereum Node in mist is showing Geth 1.5.9 (Go), which is the only option available other than none.
-Address with stuck coins: http://gastracker.io/addr/0x7cDE3FE3cDf5205418b7CE6581050C8341820B6D

I understand this may take a lot of time to fix whatever I did wrong, or are doing wrong, I understand, I just want access to my coins whilst I have an abundance of time. Just hate having over a grand worth of coins stuck in a bum wallet; it is a real buzz kill. However, if it's showing in the ETC block explorer, there should be some hope for me yet!

Didn't have much time until now either so, now's a good time for me to deal with this.

So long's we can get the wallet updating, it's all it needs, a bumpstart.

If this is in the wrong thread, please point my dumbass in the right direction.

Thank You!

-G

PS: I read around for information but for the more technical stuff, I prefer waiting and be guided rather than guide myself into doing the wrong things.

User should have UI function to switch between testnet/mainnet

Currently in wallet if one selects testnet, and reloads page in browser, we lossing correct chain specifier (after reload it allways MAINNET).
@dulanov , should we add new rpc call for chain syncing ?

Such as decimals, symbol and name.

App should allow user to override this parameters, and store the under options: { erc20: ... } in contract profile

Expected: When user send invalid Keyfile, wallet should react with erro message,
Actually: Wallet shows last account from list.

Instead of using hardcoded hex values, use the getFunctionSignature function in convert.js
To be refactored:

• transferTokenTransaction
• loadTokenBalanceOf
• loadTokenDetails

json_rpc lib lacks support for Authorization header, so wee need to return
passphrase inside JSON.

https://github.com/ethereumproject/emerald-wallet/issues/42

Should show value of all installed tokens in addition to Ether value on Account details screen

Changes only by manual refresh, not automatically in background:

Give user an option to "Approve" instead of transfer when user selects a token in transfer dialog

Issue arose after #53
I may have broken something in the merge.

Target Address should also autocomplete with user's other addresses

Add button "add token" and show a form on click with token ERC20 address. Then extract additional information from that address

Try to execute tx before sending, to (1) find errors, and (2) to calculate requited gas

Wallet can't show proper account details in address book.

Can use estimateGas when creating transaction, but trace_call should be used for validation.

trace_call provides a more accurate gas estimate.
(http://ethereum.stackexchange.com/questions/266/what-are-the-limitations-to-estimategas-and-when-would-its-estimate-be-considera)

There is invalid length of fields ( hex string is not modulo of 2) inside JSON object of transaction.
gasPrice and value have odd length.

[{"from": "0x2a191e0a15dbcfaf30fa0548ed189bc77f3284ae", "gas": "0x5208", "gasPrice": "0x2540be400", "to": "0x004a301af857a471b9bde4fcc4654dba4f38272a", "value": "0xde0b6b3a76400"}]"

As I read in development update development of supporting ERC20 approve is officially going on in Emerald Wallet.

I want to pay for your attention that approve is insecure.

approve vulnerability was already described here on EDCON.

Also approve and transferFrom method usage is considered incorrect from a logical point of view because of its leading to money losses.

You can watch result of this on Ethereum and not repeat their mistakes.

There is already about $13000 lost and this amount is growing each day!
I've already wrote an article about this fact and you can browse it here on reddit.

I did a lot of research abount tokens and developed a new ERC23 token interface that can prevent such accidents.

If we don't want to officially promote, confirm and support development of insecure tokens that is leading to money losses, we need to remove approve function support from Emerald Wallet as there is an alternative way to design secure tokens.

Display market details (convert to USD/BTC/etc, totals)

On transaction form, create a transaction JSON and send it to the Connector. Show transaction id on a new screen.

https://github.com/ethereumproject/wiki/wiki/JSON-RPC#eth_sendtransaction

Allow to select token instead of Ether in transfer dialog

https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_estimategas

npm run build:

ERROR in ./src/i18n.js
Module not found: Error: Can't resolve 'i18next-xhr-backend' in 'D:\Projects\emerald-wallet\src'
 @ ./src/i18n.js 11:25-55
 @ ./src/index.js

My proposal it to introduce a secret session phrase and share it between wallet and connector.
Connector can take it from a file restricted with -rw------- (400) together with KDF (key-derivation function) details.

For every eth_sendTransaction request we can use X-Session-Key header to encrypt digest of message together with wallet's passphrase: initialization vector (16 bytes) | encrypted text | hmac (32 bytes).

Should fix security hole introduced by #42.

Languages we plan to support:

• en
• zh-cn
• zh-hk
• (Other translators?)

The translation framework is added in #80, below are individual sections to be translated:

• Account page
• Address book page
• Contracts page
• Status page
• Tokens page
• Transactions page

There is a possibility to find required keystore file by address (address is defined explicitly) or by UUID v4 (the address is hidden).

Add a card with tokens to main screen, similar to accounts card.

Display:

• name
• address
• code
• total coins

After clicking "import json" on account creation screen, it should show a new form with upload field. On click "upload" send data to the connector, and redirect user to accounts screen

Probably the issue for redesign, not for the current prototype stage:

Add tokens:

• #8 card with list of existing tokens (name, id, total coins)
• #9 add token form

User needs an address book for external addresses. Address could simplify process of reoccurring transfers.

Operations:

• show screen with addresses
• add address
• remove address
• edit address details

In Account generation screen missed field description.
Also field name isn't included into call parameters

version Ethereum Classic Geth 3.3.0

After npm run start, i have checked the JS console.
And got the message,
http://localhost:1920/ net::ERR_CONNECTION_REFUSED
I have added a --rpc to the geth
But i am not why still get this err message.

Show a spinner on top with number of non-mined transactions on it.

On click show popup with list of last transactions:

• short tx id
• confirmations count
• when sent

For example:

• Your transaction has been added! 👍
• Your new account has successfully been created! 👍
• You're not connected to a network 🤒

Specs:
Should have a consistent layout, likely floating with high z-index in a corner or something.

Component should have parameters for:

• alert message, ie "Transaction successfully processed."
• help message, ie "Click here to view your transaction."
• type ['success', 'error', 'info', 'warning']
• duration

UI should:

• display alert message in larger font than help message, and on top
• help message should give instructions about possible next steps
• type should correlate to background color (green, red, blue,...)
• duration should determine how long before message auto-disappears, maybe with 0 for never
• should have an X button to hide

Make sense? Assuming it hasn't been done yet and/or its job hasn't already been filled in some way I haven't seen (?)

Now we should extract wallet data on every request, not permanently ('unlock' feature), therefore we need also a wallet passphrase.

Create a special screen with list of installed contracts, and a form to install one

• Show installed contracts
• Add ABI for existing contract on blockchain
• Deploy new contract on blockchain

Display a new screen after click on "generate new account", with fields:

• account name (optional)
• password
• password confirmation

On click "Generate" send it to the Connector and display resulting account id on same screen and "done" button (returns to main screen)

We need to receive account file in JSON format to process it in emerald-rs.
Currently there is blob:http mock that emerald-rs can't handle.