emilbayes / blake2b Goto Github PK

Can this be used on the client-side (ie: firefox) or is there any client-side library for blake2 you can suggest?

Thanks!

Hi guys! How do you feel about TypeScript? There seems to be no types for your package. Would you mind including type definitions in the npm package? I could work on it.

Hey 👋

Is it expected that the returned hex length is double the outLength passed to blake2b()?

I would have assumed if I ran the following, I would get a hex string with a length of 32 but it returns a string with a length of 64:

const input = Buffer.from(value);
const hashedValue = blake2b(32)
  .update(input)
  .digest('hex');

return hashedValue;

Hi. I noticed hashing strings is incorrect. It hashes the zeroed input buffer instead:

blake2b(16).update('a').digest('hex')
// '7025e075d5e2f6cde3cc051a31f07660'

blake2b(16).update('b').digest('hex')
// '7025e075d5e2f6cde3cc051a31f07660'

blake2b(16).update(new Uint8Array(1)).digest('hex')
// '7025e075d5e2f6cde3cc051a31f07660'

Based on hash.update and blake2bUpdate, the effect seems to be like:

const arr = new Uint8Array(1)
arr[0] = 'a'
// that does nothing:
// arr[0] === 0
blake2b(16).update(arr).digest('hex')
// '7025e075d5e2f6cde3cc051a31f07660'

Related to this issue is hashing empty strings:

blake2b(16).update('').digest('hex')
// Error: input must be TypedArray or Buffer

Maybe this assert was intended for all strings, and not just the empty one? It could also use TextEncoder and Buffer.from for you.