emilybache / racing-car-katas Goto Github PK

I have just translated the LeaderBoard in C#
https://github.com/boucardbruno/Racing-Car-Katas-CSharp

Every link that points to cyber-dojo in the Get going quickly with Cyber-Dojo section of README display SaverService::Error messages when opened

an example is the below screenshot

Hi,

how do you expect the ruby test to be run?
I tried them but I had tho fix some require to require_relative in order to let them pass.

Am I doing something wrong?
Do you want a PR?

Hello,

I did the Kata Car TirePressureMonitoringSystem in "java" version.

I think the case to reset the alarm is missing when you call 2 times the check function:

Alarm alarm = new Alarm()
alarm.check();
=> alarm is set to true
alarm.check();
=> Here the alarm is always on event if the sensor return false.

public void check()
    {
        double psiPressureValue = sensor.popNextPressurePsiValue();

        if (psiPressureValue < LowPressureThreshold || HighPressureThreshold < psiPressureValue)
        {
            alarmOn = true;
        }
    }

So, the code could be:

public void check()
    {
        double psiPressureValue = sensor.popNextPressurePsiValue();

        alarmOn = (psiPressureValue < LowPressureThreshold || HighPressureThreshold < psiPressureValue);
    }

Thank you.
Jérôme.

Hi,
in the Java project "UnicodeFileToHtmlTextConverter" the class that should be tested it has been renamed to "HtmlTextConverter", maybe it's better to name it back to "UnicodeFileToHtmlTextConverter" to be coincise with the documentation.

Comparing the two string like showed in the snippet of code below it's not a good way, unless you're comparing the instance of the string, but I don't think this is the case since String class is immutable.

public void send(String message)
{
    // ...
    if (message == DIAGNOSTIC_MESSAGE)
    // ...
}

It should be:

public void send(String message)
{
    // ...
    if (message.equals(DIAGNOSTIC_MESSAGE))
    // ...
}

The target class is TelemetryClient of project TelemetrySystem (Java version), line 44

I came here via https://kata-log.rocks/race-car-katas-leaderboard.

My problem is that I don't understand what there is to do in the Leaderboard kata. The needed unit tests seem to already be written. What am I missing? I'm using Java; haven't looked at the other languages.

Is it intentional that the fields are not private? This makes "get it under test without changing the production code" relatively easy (which it wouldn't be otherwise)

Alarm alarm = new Alarm();
alarm.sensor = new MySensorStub();

Hi Emily, I updated the Python porting of the exercises you provided.

If you like, take a look and let me know your feedback.

Soon will present this coding dojo at a conference, after that I will make available the slides for the exercises.

Luca

Hi everyone,

In the Go version of the pressure monitoring systems exist an error in the 25 line of the sensor.go file because pressureTelemetryValue always will be the same value and is because s (in line 23) takes the same seed all the time, then, the value that assume is the same all the time.

In another hand, this kata doesn't is useful like a mocks exercise and is because to test the check function of the alarm, all that is needed is to create an instant of the alarm with different threshold, in the same way, is possible to create an instance of the sensor using anonymous functions to change the offset and samplePressure values, in that way is not needed to make a mock of anything.