emmanouilmatsis / libdht Goto Github PK

namespaced global constant variables
iterate with iterator
rule of five
composition vs inheritance of std

Node
Value
KBucket
RoutingTable
Protocol

return iterators from container wrapper classes and avoid providing accessors which return by value or even worst by const std::container &, since is not oop. http://www.drdobbs.com/custom-containers-iterators-for-stl-fri/184401929?pgno=1

1. Heap (https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Ownership_and_Smart_Pointers)
   • Dynamically allocate Node object (transferring ownership between KBuckets is cheaper that copying, simpler that 'borrowing' a reference and improve readability by making ownership explicit, self-documenting and unambiguous).
   • Exclusive ownership of dynamically allocated Node objects belongs to KBuckets. Transfer Node objects ownership between KBuckets through unique_ptr.
   • Access Node objects by-value or by-reference.

class KBucket
{
    public:
        void add(libdht::Node node)
        { nodes_.push_back(std::move(node); }
   ...
};

KBucket kbucket;
...
kbucket.add(libdht::Node(id, address, port));

1. Stack (https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Copyable_Movable_Types)
   • By-Value using Move Semantics (Item 41: Consider pass by value for copyable parameters that are cheap to move and always copied) since Node objects are very small, fast to move and could always be copied.

class KBucket
{
    public:
        void add(std::unique_ptr<libdht::Node> node)
        { nodes_.push_back(std::move(node); }
   ...
};

KBucket kbucket;
...
kbucket.add(std::make_unique<libdht::Node>(id, address, port));

understand split kbucket