Giter VIP home page Giter VIP logo

lolapi's People

Contributors

emmorts avatar lucasfevi avatar satrium avatar vaguilera avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

lolapi's Issues

Why does matchlist API sometimes work and sometimes not work?

var options = {
        rankedQueues: ['TEAM_BUILDER_DRAFT_RANKED_5x5', 'RANKED_SOLO_5X5', 'RANKED_TEAM_5X5'],
        beginIndex: 0,
        endIndex: 10
    };

    lolapi.MatchList.getBySummonerId(summonerId, options, function (error, matches) {
        // got the matches!
        console.log(matches);
    });

Most time I got matches == null
But sometimes it works....

How to retrieve Match via Array of MatchIds?

On your readme it says i can use an array of MatchIds to lookup the game data however i tried passing the array to the function but nothing happens:

lolapi.MatchList.getBySummonerId(summoner[reqName].id, options, function (error, matches) {
if (matches) {
var games = matches.matches;
var matchIds = [];
for (var i = 0; i < games.length; i++) {
matchIds.push(games[i].matchId);
}
for (var i = 0; i < matchIds.length; i++) {
lolapi.Match.get(matchIds, function (error, games) {
console.log(games);
});
}
}
});

How do I cache to a server?

I have a redis server through microsoft azure and was wondering how I would go about doing this... The hostname seems like it's not enough information for it to connect the the redis... Don't I need to include keys or something?

Error with getByTeamId and getEntriesByTeamId

Hi, i am facing an issue with 2 functions to get data by team id :

I am getting a [Error: Param id must be an integer or an array of integers]
The fact is that a Team id is not an integer, here is an example of teamId :

  • TEAM-9fa508e0-3b00-11e5-9ced-c81f66dd30e5

Thanks in advance ! ;)

Rate limit not respected

I have an application that retrieves my ranked match history. It is longer than 150 matches, so it is more than 10 pages. I am calling the pages sequentially, and it's usually fast enough that I'm hitting the 10 request per 10 second rate limit for test accounts. I'm creating my lol object using lol = require("lolapi")(config.apikey, "na") and setting the rate limit lol.setRateLimit(9, 499); to test to see if a lower limit would help, but I still get 429 rate limit errors occasionally.

I looked over the code and didn't see anything entirely obvious that would cause this, but wanted to bring it to your attention.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.