Aspera option improvement about enabrowsertools HOT 3 CLOSED

os.environ.get() works the same in both py2 and py3 and the getattr() approach should as well.

If the aspera_settings.ini file is always going to be ../ from enaDataGet.py and utils.py and you wanted to save that full path as a place to check when a specific file isn't provided and env var unset, you could put a line inside utils.py enaBrowserTools_path = os.path.dirname(os.path.dirname(__file__)) then call on the utils module to get it.

Extend this if-statement:

elif os.environ.get('ENA_ASPERA_INIFILE'):
    aspera = True
    utils.set_aspera_variables(os.environ.get('ENA_ASPERA_INIFILE'))
elif:
    eBT_path = getattr(utils, 'enaBrowserTools_path', '')
    if os.path.exists(os.path.join(eBT_path, 'aspera_settings.ini')):
        aspera = True
        utils.set_aspera_variables(os.path.join(eBT_path, 'aspera_settings.ini'))

from enabrowsertools.

I'l have a look at this. I usually try to avoid environment variables as they can be dangerous. Though given these scripts are run locally I can probably loosen that rule

from enabrowsertools.

Added in v1.4 release.

from enabrowsertools.