end3r / gamedev-canvas-workshop Goto Github PK

Hello @end3r

I was reading the Mozilla page and it is says MDN content is under CC-BY-SA (https://developer.mozilla.org/en-US/docs/MDN/About#Copyrights_and_licenses) and the code is public domain, however your repo doesn't also have this license.

Can you add a CC and PD license to your repo as well so people can legally use your repo and the MDN page together?

In the keyDownHandler and keyUpHandler the KeyboardEvent.keyCode API is deprecated.
See details here: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode

Would you accept a PR that changes the deprecated KeyboardEvent.keyCode calls to the recommended KeyboardEvent.code?

https://github.com/search?o=desc&q=game+canvas&s=stars&type=Repositories

From MDN

In Setting up the brick variables section, you wrote " It will contain the brick columns (c), which in turn will contain the brick rows (r)...".

However, in Brick Drawing Logic, you wrote "Each brickX position is worked out as brickWidth + brickPadding, multiplied by the row number, c, plus the brickOffsetLeft; the logic for the brickY is identical except that it uses the values for column number, r, brickHeight, and brickOffsetTop."

For the latter, shouldn't it be "multiplied by the column number, c... ... row number, r..."? Because in your loop definition, when c=0, (ie. you're drawing the first column), then r=0, then r=1, r=2, the x's and y's that are returned are: [(30,30), (30,60), (30,90)]

As I understand it, columns go left to right, therefore describing things in the horizontal position, ie. the x values, and rows go up to down, therefore describing things in the vertical position, ie. the y values.

Please ignore this if I understand it wrong.

https://poltergasm.itch.io/reverie-grassland-assets

When the ball hits the bottom wall the game over alert pops up infinitely in chrome and the ball sinks into the bottom wall with each alert.

Didn't check in firefox if the issue persists there.

Where to edit the movement speed of the ball?

https://b-ok.asia/book/1293548/661c1c

Hello wonderful people,

I am working on Eclipse bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=514294

I was wondering if I could use your game to include as an example. For this to be used inside Eclipse Open Source, the licensing must be clear. Is this open-source, and if so, what is the license?

I propose we refactor the code to introduce ternary operators into this workshop.

keyDownHandler(e) and keyUpHandler(e) could easily be refactored. Maybe just refactoring one for comparison purposes, and leave the other the way it is.